<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I suggest then to pin the dependencies from [1] to below.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Couldn't be posible to just clone the openstack/puppet-* ones<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">and then use some tool to install the dependencies from them, some<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">kind of<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">  pip install -r requirements.txt<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">but adapted for Puppet? Does this tool exist?<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br>[1]: <a href="https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L111">https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L111</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 15 December 2015 at 17:46, Emilien Macchi <span dir="ltr"><<a href="mailto:emilien@redhat.com" target="_blank">emilien@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For information, Puppet OpenStack CI is consistent for unit & functional<br>
tests, we use a single (versionned) Puppetfile:<br>
<a href="https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile" rel="noreferrer" target="_blank">https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile</a><br>
<br>
TripleO folks might want to have a look at this to follow the<br>
dependencies actually supported by upstream OR if you prefer surfing on<br>
the edge and risk to break CI every morning.<br>
<br>
Let me know if you're interested to support that in TripleO Puppet<br>
elements, I can help with that.<br>
<div class="HOEnZb"><div class="h5"><br>
On 12/14/2015 02:25 PM, Dan Prince wrote:<br>
> On Fri, 2015-12-11 at 21:50 +0100, Jaume Devesa wrote:<br>
>> Hi all,<br>
>><br>
>> Today TripleO CI jobs failed because a new commit introduced on<br>
>> puppetlabs-mysql[1].<br>
>> Mr. Jiri Stransky solved it as a temporally fix by pinning the puppet<br>
>> module clone to a previous<br>
>> commit in the tripleo-common project[2].<br>
>><br>
>> source-repositories puppet element[3] allows you to pin the puppet<br>
>> module clone as well by<br>
>> adding a reference commit in the source-repository-<element-name><br>
>> file. In this case,<br>
>> I am talking about the source-repository-puppet-modules[4].<br>
>><br>
>> I know you TripleO guys are brave people that live dangerously in the<br>
>> cutting edge, but I think<br>
>> the dependencies to puppet modules not managed by the OpenStack<br>
>> community should be<br>
>> pinned to last repo tag for the sake of stability.<br>
>><br>
>> What do you think?<br>
><br>
> I've previously considered added a stable puppet modules element for<br>
> just this case:<br>
><br>
> <a href="https://review.openstack.org/#/c/184844/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/184844/</a><br>
><br>
> Using stable branches of things like MySQL, Rabbit, etc might make<br>
> sense. However I would want to consider following what the upstream<br>
> Puppet community does as well specifically because we do want to<br>
> continue using upstream openstack/puppet-* modules as well. At least<br>
> for our upstream CI.<br>
><br>
> We also want to make sure our stable TripleO jobs use the stable<br>
> branches of openstack/puppet-* so we might need to be careful about<br>
> pinning those things too.<br>
><br>
> Dan<br>
><br>
><br>
>>  I can take care of this.<br>
>><br>
>> [1]: <a href="https://github.com/puppetlabs/puppetlabs-mysql/commit/bdf4d0f52d" rel="noreferrer" target="_blank">https://github.com/puppetlabs/puppetlabs-mysql/commit/bdf4d0f52d</a><br>
>> fc244d10bbd5b67efb791a39520ed2<br>
>> [2]: <a href="https://review.openstack.org/#/c/256572/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/256572/</a><br>
>> [3]: <a href="https://github.com/openstack/diskimage-builder/tree/master/eleme" rel="noreferrer" target="_blank">https://github.com/openstack/diskimage-builder/tree/master/eleme</a><br>
>> nts/source-repositories<br>
>> [4]: <a href="https://github.com/openstack/tripleo-puppet-elements/blob/master" rel="noreferrer" target="_blank">https://github.com/openstack/tripleo-puppet-elements/blob/master</a><br>
>> /elements/puppet-modules/source-repository-puppet-modules<br>
>><br>
>> --<br>
>> Jaume Devesa<br>
>> Software Engineer at Midokura<br>
>> _____________________________________________________________________<br>
>> _____<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubs" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubs</a><br>
>> cribe<br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Emilien Macchi<br>
<br>
</font></span><br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><font face="tahoma, sans-serif">Jaume Devesa</font><div><font face="tahoma, sans-serif">Software Engineer at Midokura</font></div></div></div>
</div>