Open Stack

Thanks, Anastasia!

Who can take start documenting the rules? I remember only a few rules and I don’t know all the nuances.
For example, if the return statement is the only statement of a function – do you still need a blank line before it?

Once the rules doc will be available I can work on adding these rules to our pep8.


From: Anastasia Kuznetsova [mailto:akuznetsova at mirantis.com]
Sent: Wednesday, December 09, 2015 1:13 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines

Hi Moshe,

Great idea!

It is possible to prepare some additional code checks, for example you can take a look how it was done in Rally project [1].
Before starting such work in Mistral, I guess that we can describe our addition code style rules in our official docs (somewhere in "Developer Guide" section [2]).

[1] https://github.com/openstack/rally/tree/master/tests/hacking
[2] http://docs.openstack.org/developer/mistral/#developer-guide

On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) <moshe.elisha at alcatel-lucent.com<mailto:moshe.elisha at alcatel-lucent.com>> wrote:
Hi all,

Is it possible to add all / some of the special guidelines of Mistral (like blank line before return, period at end of comment, …) to our pep8 rules file?

This can save a lot of time for both committers and reviewers.

Thanks!

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



--
Best regards,
Anastasia Kuznetsova
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151210/35bc559d/attachment.html>