[openstack-dev] [Neutron] Netaddr 0.7.16 and gate breakage

Kevin Benton blak111 at gmail.com
Mon Aug 31 06:19:01 UTC 2015


Even if this version is fixed for valid_mac, it appears the netaddr authors
made the decision to make a backwards incompatible change WRT to the
'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and /32.
This means that all future versions of netaddr will be incompatible with
the current releases of Neutron.

I have a fix for master here: https://review.openstack.org/#/c/218723/, but
we will need to cap netaddr in global requirements for kilo and juno and
then consider back-porting the changes. Additionally, we should probably
release a note indicating that upgrading netaddr is disastrous for all
released versions of openstack using Neutron.

Cheers

On Sun, Aug 30, 2015 at 9:26 PM, Ken'ichi Ohmichi <ken1ohmichi at gmail.com>
wrote:

> Yeah,
>
> The latest netaddr seems broken.
> The behavior is changed like
>
> * PREVIOUS: netaddr-0.7.15
> >>> import netaddr
> >>>
> >>> mac = 'fa:16:3e:4e:a1:0a'
> >>> netaddr.valid_mac(mac)
> True
> >>>
>
> * LATEST: netaddr-0.7.16
> >>> import netaddr
> >>> mac = 'fa:16:3e:4e:a1:0a'
> >>> netaddr.valid_mac(mac)
> False
> >>>
>
> I posted several patches for solving this gate problem:
>
>
> https://review.openstack.org/#/q/status:open+branch:master+topic:bug/1490368,n,z
>
> Thanks
> Ken Ohmichi
>
>
> 2015-08-31 13:08 GMT+09:00 Kevin Benton <blak111 at gmail.com>:
> > Looks like a legitimate bug in netaddr for mac address validation. The
> > 'valid_mac' function gets setup twice at the top level.
> >
> >
> https://github.com/drkjam/netaddr/blob/b2b83f5d69f7b38f31330624ec9eb292b1cc880d/netaddr/__init__.py#L42-L46
> >
> > On Sun, Aug 30, 2015 at 8:54 PM, Armando M. <armamig at gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> If you wonder why hell broke loose, [1] will have the answer to your
> >> questions.
> >>
> >> Armando
> >>
> >> [1] https://bugs.launchpad.net/neutron/+bug/1490380
> >>
> >>
> __________________________________________________________________________
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>
> >
> >
> >
> > --
> > Kevin Benton
> >
> >
> __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Kevin Benton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150830/7ab824b5/attachment-0001.html>


More information about the OpenStack-dev mailing list