<div dir="ltr"><div>Even if this version is fixed for valid_mac, it appears the netaddr authors made the decision to make a backwards incompatible change WRT to the 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and /32. This means that all future versions of netaddr will be incompatible with the current releases of Neutron.</div><div><br></div><div>I have a fix for master here: <a href="https://review.openstack.org/#/c/218723/" target="_blank">https://review.openstack.org/#/c/218723/</a>, but we will need to cap netaddr in global requirements for kilo and juno and then consider back-porting the changes. Additionally, we should probably release a note indicating that upgrading netaddr is disastrous for all released versions of openstack using Neutron.</div><div><br></div><div>Cheers</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 30, 2015 at 9:26 PM, Ken'ichi Ohmichi <span dir="ltr"><<a href="mailto:ken1ohmichi@gmail.com" target="_blank">ken1ohmichi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yeah,<br>
<br>
The latest netaddr seems broken.<br>
The behavior is changed like<br>
<br>
* PREVIOUS: netaddr-0.7.15<br>
>>> import netaddr<br>
>>><br>
>>> mac = 'fa:16:3e:4e:a1:0a'<br>
>>> netaddr.valid_mac(mac)<br>
True<br>
>>><br>
<br>
* LATEST: netaddr-0.7.16<br>
>>> import netaddr<br>
>>> mac = 'fa:16:3e:4e:a1:0a'<br>
>>> netaddr.valid_mac(mac)<br>
False<br>
>>><br>
<br>
I posted several patches for solving this gate problem:<br>
<br>
<a href="https://review.openstack.org/#/q/status:open+branch:master+topic:bug/1490368,n,z" rel="noreferrer" target="_blank">https://review.openstack.org/#/q/status:open+branch:master+topic:bug/1490368,n,z</a><br>
<br>
Thanks<br>
<span class="HOEnZb"><font color="#888888">Ken Ohmichi<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
2015-08-31 13:08 GMT+09:00 Kevin Benton <<a href="mailto:blak111@gmail.com">blak111@gmail.com</a>>:<br>
> Looks like a legitimate bug in netaddr for mac address validation. The<br>
> 'valid_mac' function gets setup twice at the top level.<br>
><br>
> <a href="https://github.com/drkjam/netaddr/blob/b2b83f5d69f7b38f31330624ec9eb292b1cc880d/netaddr/__init__.py#L42-L46" rel="noreferrer" target="_blank">https://github.com/drkjam/netaddr/blob/b2b83f5d69f7b38f31330624ec9eb292b1cc880d/netaddr/__init__.py#L42-L46</a><br>
><br>
> On Sun, Aug 30, 2015 at 8:54 PM, Armando M. <<a href="mailto:armamig@gmail.com">armamig@gmail.com</a>> wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> If you wonder why hell broke loose, [1] will have the answer to your<br>
>> questions.<br>
>><br>
>> Armando<br>
>><br>
>> [1] <a href="https://bugs.launchpad.net/neutron/+bug/1490380" rel="noreferrer" target="_blank">https://bugs.launchpad.net/neutron/+bug/1490380</a><br>
>><br>
>> __________________________________________________________________________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
>><br>
><br>
><br>
><br>
> --<br>
> Kevin Benton<br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div>Kevin Benton</div></div>
</div>