Open Stack

On Fri, Apr 24, 2015 at 12:36 AM, Victor Stinner <vstinner at redhat.com>
wrote:

> Hi,
>
> I wrote my spec to Port Nova to Python 3:
> https://review.openstack.org/#/c/176868/
>
> >> I squashed all my commits into a single commit of my draft port and I
> pushed it at:
> >>
> https://github.com/haypo/nova/commit/bad54bc2b278c7c7cb7fa6cc73d03c70138bd89d
> >
> > I like how the sha1 starts with 'bad'
>
> Ah ah, I didn't notice that. I would prefer "python" prefix, but it's not
> possible.
>
> > Overall that is a pretty small patch.
>
> Cool.
>
> > My general concern, is having to manually review new code for python3
> compliance.
>
> Do you prefer a single very large patch (as the one I posted above) or
> multiple small patches fixing similar issues?


> > If this will take more then a week or two to make a big project python3
> compat (during a virtual sprint), it would be good to have some tooling in
> place to make sure we don't add a lot more burden on reviewers to make sure
> new patches are python3 compatible by hand.
>
> I tried to write a detailed plan in my spec. Until "tox -e py34" pass, I
> would prefer to not touch nova gates nor any add Python 3 checks.
>

Great, I'll follow up on that spec.


>
> Victor
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150424/2401fc66/attachment.html>