Open Stack

On 4/2/2015 2:37 AM, Markus Zoeller wrote:
> Michael Still <mikal at stillhq.com> wrote on 04/01/2015 11:01:51 PM:
>
>> From: Michael Still <mikal at stillhq.com>
>> To: "OpenStack Development Mailing List (not for usage questions)"
>> <openstack-dev at lists.openstack.org>
>> Date: 04/01/2015 11:06 PM
>> Subject: Re: [openstack-dev] [nova] unit tests result in false
>> negatives on system z platform CI
>>
>> Thanks for the detailed email on this. How about we add this to the
>> agenda for this weeks nova meeting?
>
> Yes, that would be great. I've seen you already put it on the agenda.
> I will be in todays meeting.
>
> Regards,
> Markus Zoeller (markus_z)
>
>> One option would be to add a fixture to some higher level test class,
>> but perhaps someone has a better idea than that.
>>
>> Michael
>>
>> On Wed, Apr 1, 2015 at 8:54 PM, Markus Zoeller <mzoeller at de.ibm.com>
> wrote:
>>> [...]
>>> I'm looking for a way to express
>>> the assumption that x86 should be the default platform in the unit
> tests
>>> and prevent calls to the underlying system. This has to be rewritable
> if
>>> platform specific code like in [2] has to be tested.
>>>
>>> I'd like to discuss how that could be achieved in a maintainable way.
>>>
>>>
>>> References
>>> ----------
>>> [1] https://blueprints.launchpad.net/nova/+spec/libvirt-kvm-systemz
>>> [2] test_driver.py; test_get_guest_config_with_type_kvm_on_s390;
>>>
>>> https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/
>> libvirt/test_driver.py#L2592
>
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

It's simple, don't run the unit tests on z.  We don't require the other 
virt driver CI to run unit tests, I don't see why we'd make zKVM do it. 
  Any platform-specific code should be exercised via the APIs in Tempest 
runs and the zKVM CI should be focusing on running the Tempest tests 
that hit the APIs they support (which should be listed in the hypervisor 
support matrix).

-- 

Thanks,

Matt Riedemann