Open Stack

Michael Still <mikal at stillhq.com> wrote on 04/01/2015 11:01:51 PM:

> From: Michael Still <mikal at stillhq.com>
> To: "OpenStack Development Mailing List (not for usage questions)" 
> <openstack-dev at lists.openstack.org>
> Date: 04/01/2015 11:06 PM
> Subject: Re: [openstack-dev] [nova] unit tests result in false 
> negatives on system z platform CI
> 
> Thanks for the detailed email on this. How about we add this to the
> agenda for this weeks nova meeting?

Yes, that would be great. I've seen you already put it on the agenda.
I will be in todays meeting.

Regards,
Markus Zoeller (markus_z)

> One option would be to add a fixture to some higher level test class,
> but perhaps someone has a better idea than that.
> 
> Michael
> 
> On Wed, Apr 1, 2015 at 8:54 PM, Markus Zoeller <mzoeller at de.ibm.com> 
wrote:
> > [...]
> > I'm looking for a way to express
> > the assumption that x86 should be the default platform in the unit 
tests
> > and prevent calls to the underlying system. This has to be rewritable 
if
> > platform specific code like in [2] has to be tested.
> >
> > I'd like to discuss how that could be achieved in a maintainable way.
> >
> >
> > References
> > ----------
> > [1] https://blueprints.launchpad.net/nova/+spec/libvirt-kvm-systemz
> > [2] test_driver.py; test_get_guest_config_with_type_kvm_on_s390;
> >
> > https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/
> libvirt/test_driver.py#L2592