Open Stack

On 09/16/2014 06:44 AM, Kuvaja, Erno wrote:
>> -----Original Message-----
>> From: Flavio Percoco [mailto:flavio at redhat.com]
>> Sent: 16 September 2014 10:08
>> To: openstack-dev at lists.openstack.org
>> Subject: Re: [openstack-dev] [glance][all] Help with interpreting the log level
>> guidelines
>>
>> On 09/16/2014 01:10 AM, Clint Byrum wrote:
>>> Excerpts from Sean Dague's message of 2014-09-15 16:02:04 -0700:
>>>> On 09/15/2014 07:00 PM, Mark Washenberger wrote:
>>>>> Hi there logging experts,
>>>>>
>>>>> We've recently had a little disagreement in the glance team about
>>>>> the appropriate log levels for http requests that end up failing due
>>>>> to user errors. An example would be a request to get an image that
>>>>> does not exist, which results in a 404 Not Found request.
>>>>>
>>>>> On one hand, this event is an error, so DEBUG or INFO seem a little
>>>>> too low. On the other hand, this error doesn't generally require any
>>>>> kind of operator investigation or indicate any actual failure of the
>>>>> service, so perhaps it is excessive to log it at WARN or ERROR.
>>>>>
>>>>> Please provide feedback to help us resolve this dispute if you feel you
>> can!
>>>>
>>>> My feeling is this is an INFO level. There is really nothing the
>>>> admin should care about here.
>>>
>>> Agree with Sean. INFO are useful for investigations. WARN and ERROR
>>> are cause for alarm.
>>
>> +1 this is what we do in Zaqar as well.
>>
>>
>> --
>> @flaper87
>> Flavio Percoco
>>
> 
> I think the debate here does not only limit to 404s. By the logging guidelines INFO level messages should not contain any error related messages but rather stuff like certain components starting/stopping, config info, etc. WARN should not be anything that gets the ops pulled out of bed and so on. 
> 
> Also all information that would be in interest of ops should be logged INFO+.
> 
> Now if we are logging user errors as WARN that makes the environment supportable even if the logging has been set as high as WARN cleaning the output a lot (as INFO shouldn't contain anything out of order anyways). Current situation is that logging at DEBUG level is the only option to get the needed information to actually run the services and get the data needed to support it as well. If we log user errors on INFO we get one step higher but we still have all that clutter like every single request in the logs and if that's the direction we want to go, we should revisit our logging guidelines as well.
> 
> Thus my two euro cents goes towards WARN rather than debug and definitely not INFO.

Part of it is how often you expect things to happen as well. Remember
glanceclient opperates in the context of "other" processes. When it hits
a 404 in Glance, it's not running in the glance context, it's running in
the Nova context. Which means it needs to think of itself in that context.

In that context we got the exception back from Glance, we know the image
wasn't there. And we know whether or not that's a problem (glanceclient
actually has no idea if it's a problem or not, we might be checking to
make sure a thing isn't there, and success for us is the 404).

So actually, I'm back to Jay on this, it should be DEBUG. Nova (or
whoever the caller is) can decide if the issue warents something larger
than that.

This is really the biggest issue with logging in the clients, people
don't think about the context that they are running in.

	-Sean

-- 
Sean Dague
http://dague.net