Excellent! I'm also looking forward to see -1 on all shell code which exceeds 50 lines at some point in the future... :) On Wed, Oct 15, 2014 at 2:32 PM, Aleksandr Didenko <adidenko at mirantis.com> wrote: > Hi, > > we've merged [1] into master, so when you create new gerrit review for > fuel-library, our CI job [2] will run syntax check (depending on file type) > for all the files found under "*/files/ocf/*" path. > > So if you want to ship OCF script as a file in your module, please put it > in "MODULE/files/ocf/" directory, like in [3] and [4] for example. > > > [1] https://review.openstack.org/#/c/126841/5 > [2] https://fuel-jenkins.mirantis.com/job/fuellib_review_syntax_check/ > [3] > https://github.com/stackforge/fuel-library/tree/master/deployment/puppet/galera/files/ocf > [4] > https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/galera/manifests/init.pp#L206-L212 > > Regards, > Aleksandr Didenko > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Mike Scherbakov #mihgen -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20141015/fd722136/attachment.html>