<div dir="ltr">Excellent!<div>I'm also looking forward to see -1 on all shell code which exceeds 50 lines at some point in the future... :)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 2:32 PM, Aleksandr Didenko <span dir="ltr"><<a href="mailto:adidenko@mirantis.com" target="_blank">adidenko@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi,<br><br></div>we've merged [1] into master, so when you create new gerrit review for fuel-library, our CI job [2] will run syntax check (depending on file type) for all the files found under "*/files/ocf/*" path.<br></div><br>So if you want to ship OCF script as a file in your module, please put it in "MODULE/files/ocf/" directory, like in [3] and [4] for example.<br><div><div><div><br><br>[1] <a href="https://review.openstack.org/#/c/126841/5" target="_blank">https://review.openstack.org/#/c/126841/5</a><br>[2] <a href="https://fuel-jenkins.mirantis.com/job/fuellib_review_syntax_check/" target="_blank">https://fuel-jenkins.mirantis.com/job/fuellib_review_syntax_check/</a><br>[3] <a href="https://github.com/stackforge/fuel-library/tree/master/deployment/puppet/galera/files/ocf" target="_blank">https://github.com/stackforge/fuel-library/tree/master/deployment/puppet/galera/files/ocf</a><br>[4] <a href="https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/galera/manifests/init.pp#L206-L212" target="_blank">https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/galera/manifests/init.pp#L206-L212</a><br><br></div><div>Regards,<br>Aleksandr Didenko<br></div></div></div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Mike Scherbakov<br>#mihgen<br><br></div>
</div>