[openstack-dev] [nova] Proposal new hacking rules
jordan.pittier at scality.com
Fri Nov 21 18:15:49 UTC 2014
I am not a Nova developer but I still have an opinion.
>Using boolean assertions
I like what you propose. We should use and enforce the assert* that best matches the intention. It's about semantic and the more precise we are, the better.
>Using same order of arguments in equality assertions
Why not. But I don't know how we can write a Hacking rule for this. So you may fix all the occurrences for this now, but it might get back in the future.
>Using LOG.warn instead of LOG.warning
I am -1 on this. The part that comes after LOG. (LOG.warning, LOG.error, LOG.debug, etc) is the log level, it's not a verb. In syslog, the well-known log level is "warning" so the correct method to use here is, imo, log.warning().
Have you concidered submitting this hacking rules to the hacking project here : https://github.com/openstack-dev/hacking ? I am sure these new rules makes sense on other openstack projects.
----- Original Message -----
From: "Sahid Orentino Ferdjaoui" <sahid.ferdjaoui at redhat.com>
To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Sent: Friday, November 21, 2014 5:57:14 PM
Subject: Re: [openstack-dev] [nova] Proposal new hacking rules
On Thu, Nov 20, 2014 at 02:00:11PM -0800, Joe Gordon wrote:
> On Thu, Nov 20, 2014 at 9:49 AM, Sahid Orentino Ferdjaoui <
> sahid.ferdjaoui at redhat.com> wrote:
> > This is something we can call nitpiking or low priority.
> This all seems like nitpicking for very little value. I think there are
> better things we can be focusing on instead of thinking of new ways to nit
> pick. So I am -1 on all of these.
Yes as written this is low priority but something necessary for a
project like Nova it is.
Considered that I feel sad to take your time. Can I suggest you to
take no notice of this and let's others developers working on Nova too
do this job ?
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
More information about the OpenStack-dev