[openstack-dev] [Neutron] Stale patches

Carl Baldwin carl at ecbaldwin.net
Tue Nov 18 17:28:49 UTC 2014


On Tue, Nov 18, 2014 at 7:39 AM, Jeremy Stanley <fungi at yuggoth.org> wrote:
> This has come up before... if you don't want to see stale patches
> you can use Gerrit queries or custom dashboards to only show you
> patches with recent activity. If all patches older than some
> specific date get abandoned, then that impacts the view of these
> patches for every reviewer. Selectively abandoning patches because
> they're no longer relevant makes sense, but just automatically
> abandoning them because _some_ reviewers don't want to see old
> changes is a disservice to other reviewers who don't have the same
> personal preference. I'd rather our infrastructure empowered
> reviewers to look at the changes they *want* to see, not tell them
> which changes they're *supposed* to review.

I see your point here.  We're all going to have our own
customizations, of course but the fact that Salvatore took his time --
which is precious to the project -- to go through and abandon stale
patches and his effort was met with applause and congratulations says
something to me.  It says that, as a project, we want this.  If I'm
speaking out of turn, please speak up and let me know.

I personally don't enjoy customizing my own view more than I have to.
I see it as kind of an annoyance.  I'd rather not have to and be free
to focus on other project issues.

Carl



More information about the OpenStack-dev mailing list