[openstack-dev] [Neutron] Stale patches
Sullivan, Jon Paul
JonPaul.Sullivan at hp.com
Tue Nov 18 15:37:02 UTC 2014
> -----Original Message-----
> From: Jeremy Stanley [mailto:fungi at yuggoth.org]
> Sent: 18 November 2014 14:40
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [Neutron] Stale patches
> On 2014-11-18 05:55:55 +0000 (+0000), Kenichi Oomichi wrote:
> > I am not concentrating on Neutron devs, but I also have the same
> > feeling on the other area devs. I also cannot abandon the other
> > developers' patches even if non-activities against some negative
> > feedback.
> This has come up before... if you don't want to see stale patches you
> can use Gerrit queries or custom dashboards to only show you patches
> with recent activity. If all patches older than some specific date get
> abandoned, then that impacts the view of these patches for every
> reviewer. Selectively abandoning patches because they're no longer
> relevant makes sense, but just automatically abandoning them because
> _some_ reviewers don't want to see old changes is a disservice to other
> reviewers who don't have the same personal preference. I'd rather our
> infrastructure empowered reviewers to look at the changes they *want* to
> see, not tell them which changes they're *supposed* to review.
I saw mail targeted towards nova earlier that Sean Dague was going to write an auto-abandon script to abandon patches with negative feedback for nova.
Perhaps that script could be reused by other projects that see value in it.
This was also brought up for the tripleo projects before, where I think the idea was mainly positively thought of (I am definitely an advocate for it).
> Jeremy Stanley
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
Jon-Paul Sullivan ☺ Cloud Services - @hpcloud
Postal Address: Hewlett-Packard Galway Limited, Ballybrit Business Park, Galway.
Registered Office: Hewlett-Packard Galway Limited, 63-74 Sir John Rogerson's Quay, Dublin 2.
Registered Number: 361933
The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender.
To any recipient of this message within HP, unless otherwise stated, you should consider this message and attachments as "HP CONFIDENTIAL".
More information about the OpenStack-dev