On 04/29/2014 02:48 PM, Doug Hellmann wrote: > I have exported the gettextutils code and related files to a new git > repository, ready to be imported as oslo.i18n. Please take a few > minutes to look over the files and give it a sanity check. > > https://github.com/dhellmann/oslo.i18n > > Thanks, > Doug No functional issues, just a few cleanups: Would be nice to fix up: https://github.com/dhellmann/oslo.i18n/blob/master/tests/fakes.py#L17 Also: https://github.com/dhellmann/oslo.i18n/blob/master/oslo/i18n/gettextutils.py#L22 Are we leaving the globals in https://github.com/dhellmann/oslo.i18n/blob/master/oslo/i18n/gettextutils.py#L118 until the integration modules are done? That's all I noticed looking through the repo. None of it's a big deal (we can fix it all after import if necessary) and the unit tests are passing locally for me. -Ben