[openstack-dev] [qa] [Infra] pep8 issues in tempest gate / testscenarios lib
joe.gordon0 at gmail.com
Mon Mar 17 18:13:05 UTC 2014
On Thu, Mar 13, 2014 at 8:14 AM, Koderer, Marc <m.koderer at telekom.de> wrote:
> Hi folks,
> I can't make it to the QA meeting for today so I wanted to summarize the
> that we have with the pep8 and tempest gate. An example for the issue you
> find here:
> pep8 check shows an error but the check itself is marked as success.
> For me this show two issues. First flake8 should return with an exit code
> I will have a closer look into hacking and what went wrong here.
This was an intentional compromise. At the time of doing that we didn't
have consensus that any module should be importable without a stacktrace.
If we want to make that a rule, something which I am favor of, we can just
add a new hacking rule.
> Second issue is the current implementation of the negative testing
> we are using the testscenarios lib with the "load_tests" variable
> by the test runner. This forces us to build the scenario at import time
> and if
> we want to have tempest configurations for this (like introduced in
> https://review.openstack.org/#/c/73982/) the laziness for the config
> Although it seems like if I remove the inheritance of the xml class to the
> json class (
> that error doesn't appear any longer, I see a general problem with
> the usage of "import-time" code and we may think about a better solution
> in general.
> I'll try to address the missing pieces tomorrow.
> Bug: https://bugs.launchpad.net/tempest/+bug/1291826
> DEUTSCHE TELEKOM AG
> Digital Business Unit, Cloud Services (P&I)
> Marc Koderer
> Cloud Technology Software Developer
> T-Online-Allee 1, 64211 Darmstadt
> E-Mail: m.koderer at telekom.de
> LIFE IS FOR SHARING.
> DEUTSCHE TELEKOM AG
> Supervisory Board: Prof. Dr. Ulrich Lehner (Chairman)
> Board of Management: René Obermann (Chairman),
> Reinhard Clemens, Niek Jan van Damme, Timotheus Höttges,
> Dr. Thomas Kremer, Claudia Nemat, Prof. Dr. Marion Schick
> Commercial register: Amtsgericht Bonn HRB 6794
> Registered office: Bonn
> BIG CHANGES START SMALL - CONSERVE RESOURCES BY NOT PRINTING EVERY E-MAIL.
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev