[openstack-dev] [qa] [Infra] pep8 issues in tempest gate / testscenarios lib

Koderer, Marc m.koderer at telekom.de
Thu Mar 13 15:14:07 UTC 2014


Hi folks,

I can't make it to the QA meeting for today so I wanted to summarize the issue
that we have with the pep8 and tempest gate. An example for the issue you can
find here:
  https://review.openstack.org/#/c/79256/ 
  http://logs.openstack.org/56/79256/1/gate/gate-tempest-pep8/088cc12/console.html

pep8 check shows an error but the check itself is marked as success.

For me this show two issues. First flake8 should return with an exit code !=0.
I will have a closer look into hacking and what went wrong here.

Second issue is the current implementation of the negative testing framework:
we are using the testscenarios lib with the "load_tests" variable interpreted
by the test runner. This forces us to build the scenario at import time and if
we want to have tempest configurations for this (like introduced in
https://review.openstack.org/#/c/73982/) the laziness for the config doesn't
work.

Although it seems like if I remove the inheritance of the xml class to the
json class (https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_flavors_negative_xml.py#L24)
that error doesn't appear any longer, I see a general problem with
the usage of "import-time" code and we may think about a better solution in general.

I'll try to address the missing pieces tomorrow.
Bug: https://bugs.launchpad.net/tempest/+bug/1291826

Regards,
Marc

DEUTSCHE TELEKOM AG
Digital Business Unit, Cloud Services (P&I)
Marc Koderer
Cloud Technology Software Developer
T-Online-Allee 1, 64211 Darmstadt
E-Mail: m.koderer at telekom.de
www.telekom.com   

LIFE IS FOR SHARING. 

DEUTSCHE TELEKOM AG
Supervisory Board: Prof. Dr. Ulrich Lehner (Chairman)
Board of Management: René Obermann (Chairman),
Reinhard Clemens, Niek Jan van Damme, Timotheus Höttges,
Dr. Thomas Kremer, Claudia Nemat, Prof. Dr. Marion Schick
Commercial register: Amtsgericht Bonn HRB 6794
Registered office: Bonn

BIG CHANGES START SMALL – CONSERVE RESOURCES BY NOT PRINTING EVERY E-MAIL.


More information about the OpenStack-dev mailing list