Open Stack

On Wed, Jan 15, 2014 at 5:28 AM, Frittoli, Andrea (Cloud Services) <
frittoli at hp.com> wrote:

> Hi all,
>
>
>
> I’ve been working on a patch to ensure that all tempest tests are able to
> handle rate limiting errors with automatic retries [0].
>
> API tests already implement retries, however scenario tests don’t, the
> main reason being that scenario tests rely on the official python bindings,
> most of which do not handle retries (with the exception of the swift
> client).
>
>
>
> My approach so far has been to monkey-patch python-bindings in tempest to
> add the retry logic, however a few pointed out that the right place to
> implement the retries would be in the python bindings directly.
>
> I filed a bug [1] about implementing retries in the various python
> bindings, and I’d like to get some feedback from the community.
>
>
>
> Even if  we have enough consensus about [1], I expect it might be a while
> until all python bindings are updated.
>
> In the meanwhile I think we could go ahead with [0], and then start
> removing the monkey-patch as soon as retries are implemented on the client
> side.
>

Besides monkey patching being scary and dangerous, monkey patching the
clients in tempest means that we are now gating the clients on if the
monkey patch is still valid. So we can't change the clients in a way that
would break the monkey patch.  Although we could put the monkey patching in
a try/except clause as long as we don't exercise this in the gate.


>
>
> andrea
>
>
>
> [0] https://review.openstack.org/#/c/61978/
>
> [1] https://bugs.launchpad.net/python-novaclient/+bug/1263069
>
>
>
>
>
> --
>
> Andrea Frittoli
>
> IaaS Systems Engineering Team
>
> HP Cloud Services
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140115/9fff353b/attachment.html>