Open Stack

>
>
>> On Wed, Jan 8, 2014 at 10:43 AM, Eric Windisch <ewindisch at docker.com>  
>> wrote:
>
>>>
>>>
>>>
>>>>
>>>>
>>>>
>>>> About spur: spur is looks ok, but it a bit complicated inside (it uses
>>>>
>>>> separate threads for non-blocking stdin/stderr reading [1]) and I  
>>>> don't
>>>>
>>>> know how it would work with eventlet.
>>>
>>> That does sound like it might cause issues. What would we need to do  
>>> to test it?
>>>
>>>>>>
>>>
>>>
>>
>> Looking at the code, I don't expect it to be an issue. The  
>> monkey-patching will cause eventlet.spawn >>to be called for  
>> threading.Thread. The code looks eventlet-friendly enough on the  
>> surface. Error >>handing around file read/write could be affected, but  
>> it also looks fine.
>>
>
> Thanks for that analysis Eric.
>
> Is there any reason for us to prefer one approach over the other, then?
>
> Doug

So, there is only one reason left -- oslo lib is more simple and  
lightweight
(not using threads). Anyway this class is used by stackforge/rally and
may be used by other projects instead of buggy oslo.processutils.ssh.



-- 
Regards,
Sergey Skripnick