[openstack-dev] [oslo] Common SSH

Doug Hellmann doug.hellmann at dreamhost.com
Wed Jan 8 16:48:37 UTC 2014


On Wed, Jan 8, 2014 at 10:43 AM, Eric Windisch <ewindisch at docker.com> wrote:

>
>>
>>> About spur: spur is looks ok, but it a bit complicated inside (it uses
>>> separate threads for non-blocking stdin/stderr reading [1]) and I don't
>>> know how it would work with eventlet.
>>>
>>
>> That does sound like it might cause issues. What would we need to do to
>> test it?
>>
>
> Looking at the code, I don't expect it to be an issue. The monkey-patching
> will cause eventlet.spawn to be called for threading.Thread. The code looks
> eventlet-friendly enough on the surface. Error handing around file
> read/write could be affected, but it also looks fine.
>

Thanks for that analysis Eric.

Is there any reason for us to prefer one approach over the other, then?

Doug



>
>
> --
> Regards,
> Eric Windisch
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140108/fc91bbe9/attachment.html>


More information about the OpenStack-dev mailing list