[openstack-dev] [OpenStack-dev][Cinder] Driver stats return value: infinite or unavailable

Eduard Matei eduard.matei at cloudfounders.com
Thu Dec 18 18:41:16 UTC 2014


Thanks John,
I updated to unknown.

Eduard

On Thu, Dec 18, 2014 at 8:09 PM, John Griffith <john.griffith8 at gmail.com>
wrote:

> On Thu, Dec 18, 2014 at 1:56 AM, Eduard Matei
> <eduard.matei at cloudfounders.com> wrote:
> > Hi everyone,
> >
> > We're in a bit of a predicament regarding review:
> > https://review.openstack.org/#/c/130733/
> >
> > Two days ago it got a -1 from John G asking to change infinite to
> > unavailable although the docs clearly say that "If the driver is unable
> to
> > provide a value for free_capacity_gb or total_capacity_gb, keywords can
> be
> > provided instead. Please use ‘unknown’ if the array cannot report the
> value
> > or ‘infinite’ if the array has no upper limit."
> > (http://docs.openstack.org/developer/cinder/devref/drivers.html)
> >
> > After i changed it, came Walter A. Boring IV and gave another -1 saying
> we
> > should return infinite.
> >
> > Since we use S3 as a backend and it has no upper limit (technically
> there is
> > a limit but for the purposes of our driver there's no limit as the
> backend
> > is "elastic") we could return infinite.
> >
> > Anyway, the problem is that now we missed the K-1 merge window although
> the
> > driver passed all tests (including cert tests).
> >
> > So please can someone decide which is the correct value so we can use
> that
> > and get the patched approved (unless there are other issues).
> >
> > Thanks,
> > Eduard
> > --
> >
> > Eduard Biceri Matei, Senior Software Developer
> > www.cloudfounders.com
> >  | eduard.matei at cloudfounders.com
> >
> >
> >
> > CloudFounders, The Private Cloud Software Company
> >
> > Disclaimer:
> > This email and any files transmitted with it are confidential and
> intended
> > solely for the use of the individual or entity to whom they are
> addressed.
> > If you are not the named addressee or an employee or agent responsible
> for
> > delivering this message to the named addressee, you are hereby notified
> that
> > you are not authorized to read, print, retain, copy or disseminate this
> > message or any part of it. If you have received this email in error we
> > request you to notify us by reply e-mail and to delete all electronic
> files
> > of the message. If you are not the intended recipient you are notified
> that
> > disclosing, copying, distributing or taking any action in reliance on the
> > contents of this information is strictly prohibited.
> > E-mail transmission cannot be guaranteed to be secure or error free as
> > information could be intercepted, corrupted, lost, destroyed, arrive
> late or
> > incomplete, or contain viruses. The sender therefore does not accept
> > liability for any errors or omissions in the content of this message, and
> > shall have no liability for any loss or damage suffered by the user,
> which
> > arise as a result of e-mail transmission.
> >
> >
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> Hi Eduard,
>
> First, I owe you an apology; I stated "unavailable" in the review, but
> should've stated "unknown".  We're in the process of trying to
> eliminate the reporting of infinite as it screwed up the weighing
> scheduler.
>
> Note that Zhiteng adjusted the scheduler so this isn't such a big deal
> anymore by down-grading the handling of infinite and unknown [1].
>
> Anyway, my suggestion to not use infinite is because in the coming
> weeks I'd like to remove infinite from the stats reporting altogether,
> and for those backends that for whatever reason don't know how much
> capacity they have use a more accurate report of "unknown".
>
> Sorry for the confusion, I think the comments on your review have been
> updated to reflect this, if not I'll do that next.
>
> Thanks,
> John
>
> [1]:
> https://github.com/openstack/cinder/commit/ee9d30a73a74a2e1905eacc561c1b5188b62ca75
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 

*Eduard Biceri Matei, Senior Software Developer*
www.cloudfounders.com
 | eduard.matei at cloudfounders.com



*CloudFounders, The Private Cloud Software Company*

Disclaimer:
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed.
If you are not the named addressee or an employee or agent responsible
for delivering this message to the named addressee, you are hereby
notified that you are not authorized to read, print, retain, copy or
disseminate this message or any part of it. If you have received this
email in error we request you to notify us by reply e-mail and to
delete all electronic files of the message. If you are not the
intended recipient you are notified that disclosing, copying,
distributing or taking any action in reliance on the contents of this
information is strictly prohibited.
E-mail transmission cannot be guaranteed to be secure or error free as
information could be intercepted, corrupted, lost, destroyed, arrive
late or incomplete, or contain viruses. The sender therefore does not
accept liability for any errors or omissions in the content of this
message, and shall have no liability for any loss or damage suffered
by the user, which arise as a result of e-mail transmission.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20141218/d0136e88/attachment.html>


More information about the OpenStack-dev mailing list