Open Stack

On 08/15/2014 02:30 AM, Dougal Matthews wrote:
> Great stuff, really happy to see Python 3 support.
> 
> ----- Original Message -----
>> From: "Steve Kowalik" <steven at wedontsleep.org>
>> To: openstack-dev at lists.openstack.org
>> Sent: Friday, 15 August, 2014 4:11:04 AM
>> Subject: [openstack-dev] [TripleO] Python 3 support in os-*-config
>>
>>  * os-apply-config
>>    This one looks to be the hardest one to port. Multiple test failures,
>> hard coded use of '#!/usr/bin/env python' which is unhappy in a only
>> Python 3 environment, map() changes, byte changes ...

Strange.  How is /usr/bin/env python causing issues?  I thought the
whole point of using env to look up python was to allow it to select the
correct one based on the system configuration.

> 
> If I can help somehow, let me know.
> 
> 
>>  * os-cloud-config
>>    I have a patch to fix current Python 3 issues up
>> (https://review.openstack.org/111606), and then my plan is to add Python
>> 3 jobs to check *and* gate, so in-flight patches may need to watch out
>> for that soon.
> 
> LGTM.
> 
> 
>>  * os-collect-config
>>    This needs six sprinkled throughout it due to URL parsing, and I need
>> to work out what to do WRT absolute importing due to:
>>   File "./os_collect_config/collect.py", line 25, in <module>
>>     from openstack.common import log
>> ImportError: No module named 'openstack'
> 
> I think the import needs to be changed to this, as openstack is under the
> os_collect_config package.
> 
>     from os_collect_config.openstack.common import log

+1.  This is how all the other projects use openstack.common.

> 
> Alternatively, `from .openstack.common import log` should work but that 
> is less favorable.
> 
> 
>>  * os-net-config
>>    I know this isn't really a thing yet, but I also have yet to look
>> into it's Python 3 support.
>>
>>  * os-refresh-config
>>    This has Python 3 jobs running in check and gate. Does anyone have a
>> small fix to test them out, the last code change that landed in
>> os-refresh-config was mid July.
> 
> I don't have a change, but FWIW I just tried the tests locally on py33 
> and they passed fine. \o/
> 
> Thanks,
> Dougal
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>