[openstack-dev] [oslo][db] oslo.db repository review request

Doug Hellmann doug.hellmann at dreamhost.com
Fri Apr 25 12:46:02 UTC 2014


On Fri, Apr 25, 2014 at 8:33 AM, Matt Riedemann
<mriedem at linux.vnet.ibm.com> wrote:
>
>
> On 4/18/2014 1:18 PM, Doug Hellmann wrote:
>>
>> Nice work, Victor!
>>
>> I left a few comments on the commits that were made after the original
>> history was exported from the incubator. There were a couple of small
>> things to address before importing the library, and a couple that can
>> wait until we have the normal code review system. I'd say just add new
>> commits to fix the issues, rather than trying to amend the existing
>> commits.
>>
>> We haven't really discussed how to communicate when we agree the new
>> repository is ready to be imported, but it seems reasonable to use the
>> patch in openstack-infra/config that will be used to do the import:
>> https://review.openstack.org/#/c/78955/
>>
>> Doug
>>
>> On Fri, Apr 18, 2014 at 10:28 AM, Victor Sergeyev
>> <vsergeyev at mirantis.com> wrote:
>>>
>>> Hello all,
>>>
>>> During Icehouse release cycle our team has been working on splitting of
>>> openstack common db code into a separate library blueprint [1]. At the
>>> moment the issues, mentioned in this bp and [2] are solved and we are
>>> moving
>>> forward to graduation of oslo.db. You can find the new oslo.db code at
>>> [3]
>>>
>>> So, before moving forward, I want to ask Oslo team to review oslo.db
>>> repository [3] and especially the commit, that allows the unit tests to
>>> pass
>>> [4].
>>>
>>> Thanks,
>>> Victor
>>>
>>> [1] https://blueprints.launchpad.net/oslo/+spec/oslo-db-lib
>>> [2] https://wiki.openstack.org/wiki/Oslo/GraduationStatus#oslo.db
>>> [3] https://github.com/malor/oslo.db
>>> [4]
>>>
>>> https://github.com/malor/oslo.db/commit/276f7570d7af4a7a62d0e1ffb4edf904cfbf0600
>>>
>>> _______________________________________________
>>> OpenStack-dev mailing list
>>> OpenStack-dev at lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> I'm probably just late to the party, but simple question: why is it in the
> malor group in github rather than the openstack group, like oslo.messaging
> and oslo.rootwrap?  Is that temporary or will it be moved at some point?

This is the copy of the code being prepared to import into a new
oslo.db repository. It's easier to set up that temporary hosting on
github. The repo has been approved to be imported, and after that
happens it will be hosted on our git server like all of the other oslo
libraries.

Doug

>
> --
>
> Thanks,
>
> Matt Riedemann
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list