[openstack-dev] Testing before sending for review

Ben Nemec openstack at nemebean.com
Wed Oct 23 15:11:40 UTC 2013


On 2013-10-23 04:29, Rosa, Andrea (HP Cloud Services) wrote:
> Hi
> 
>> 2. Before submitting the new patch for review it's better to run unit 
>> tests (tox -epy27) and pep8 check (tox -epep8)
> 
> Instead of pep8 I think you should run flake8 we moved to that some
> months ago[1].
> Usually I find always useful to test my changes in devstack.
> Regards
> --
> Andrea Rosa
> 
> [1] 
> http://lists.openstack.org/pipermail/openstack-dev/2013-May/009178.html

tox -epep8 actually runs flake8.  It just wasn't renamed to avoid 
breaking people's existing workflow.

Also, just running "tox" will run all of the appropriate tests for your 
environment, which is probably what you want before pushing changes.  
Specifying -e is useful while you're working on something though so you 
don't have to run flake8 every time.

-Ben



More information about the OpenStack-dev mailing list