Open Stack

OK Dan,


On 20 October 2013 16:08, Dan Smith <dms at danplanet.com> wrote:

>  > I'm afraid I really need help now - in particular on how to add a
> > suitable test case. I've been looking at
> > /opt/stack/nova/nova/tests/compute/test_compute_api.py running
> > test_create_quota_exceeded_messages under the debugger to understand
> > how it works to be able to adapt it.
>
> I really think this discussion should be kept in the review, or taken to
> the mailing list.
>

As I don't see how to "keep it in the review", I'll copy to openstack-dev.


 > * When I have a fix I will abandon the current "change" and submit a
>
>> > new comprehensive "change".
>
>>
> Please do _not_ do that. You should have one review per logical change,
> regardless of how many iterations it takes to get it into suitable shape.>
> I don't see a way around this due to the unittest breakage which
> > spans nova/oslo (bare in mind I'm struggling/learning with
> > *everything* here) so I'm unsure how to resync my code in a safe and
>  > *reliable* way.
>

OK, I think I see what I need to do to do to not abandon the current
change<https://review.openstack.org/#/c/51263/> (i.e.
to merge with master whilst not breaking my DevStack) - I'll be back for
help if I muck up!


>  The test failure in the bug you quoted shouldn't be blocking you. You
>
>> might need to ignore it in your own local runs for a bit. That said, the
>
>> patch has supposedly been merged to master so you probably just need to
> rebase your patch on master.
>

There was no test failure, the existing tests have nothing to detect
whether the fix for
    Bug #1224453 “min_count ignored for instance create” : Bugs : OpenStack
Compute (nova) <https://bugs.launchpad.net/nova/+bug/1224453>
is present or not.

If some kind soul can guide me on adding unit tests - per my question below
- then I'll add them, otherwise I'll just complete the fix for now and add
the tests in a later change.

> I'm afraid I really need help now - in particular on how to add a
suitable test case.
> I've been looking at /opt/stack/nova/nova/tests/compute/test_compute_api.py
running test_create_quota_exceeded_messages under the debugger to
understand how it works to be able to adapt it.
> I'm too inexperienced on this to know how to write a suitable unit test
(am I even considering this in the correct file?).
> I don't have a good understanding of the current test code and I don't
see how I can do quota setting in test_compute_api.py.

Thanks,
Mike.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131020/938a45f4/attachment.html>