<div dir="ltr"><br><div class="gmail_quote"><div class="HOEnZb"><div class="h5"><div dir="ltr"><span style="color:rgb(80,0,80)">OK Dan,</span><br><div class="gmail_quote"><div><div><div dir="ltr"><div class="gmail_quote">
<div><div><div dir="ltr"><div class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br><br><span style="color:rgb(80,0,80)">On 20 October 2013 16:08, Dan Smith </span><span dir="ltr" style="color:rgb(80,0,80)"><<a href="mailto:dms@danplanet.com" target="_blank">dms@danplanet.com</a>></span><span style="color:rgb(80,0,80)"> wrote:</span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><div class="gmail_extra"><div class="gmail_quote">
<div>
> I'm afraid I really need help now - in particular on how to add a<br>> suitable test case. I've been looking at<br>> /opt/stack/nova/nova/tests/compute/test_compute_api.py running<br>> test_create_quota_exceeded_messages under the debugger to understand<br>
> how it works to be able to adapt it.<br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
</blockquote>I really think this discussion should be kept in the review, or taken to<br>
the mailing list.<br></div></div></div></div></div></blockquote><font color="#500050"><br></font></div>As I don't see how to "keep it in the review", I'll copy to openstack-dev.<div><br><font color="#500050"><br>
</font><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div class="gmail_extra"><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;border-right-width:1px;border-right-color:rgb(204,204,204);border-right-style:solid;padding-left:1ex;padding-right:1ex">
</blockquote>> * When I have a fix I will abandon the current "change" and submit a<br><blockquote class="gmail_quote" style="margin:0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;border-right-width:1px;border-right-color:rgb(204,204,204);border-right-style:solid;padding-left:1ex;padding-right:1ex">
</blockquote>> new comprehensive "change".<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
</blockquote><br><blockquote class="gmail_quote" style="margin:0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;border-right-width:1px;border-right-color:rgb(204,204,204);border-right-style:solid;padding-left:1ex;padding-right:1ex">
</blockquote>Please do _not_ do that. You should have one review per logical change,<br>
regardless of how many iterations it takes to get it into suitable shape.> I don't see a way around this due to the unittest breakage which<br>> spans nova/oslo (bare in mind I'm struggling/learning with<br>
> *everything* here) so I'm unsure how to resync my code in a safe and<br>
<div>
> *reliable* way.<br></div></div></div></div></div></blockquote><font color="#500050"><br></font>OK, I think I see what I need to do to do to not abandon the <a href="https://review.openstack.org/#/c/51263/" target="_blank">current change</a> (i.e. to merge with master whilst not breaking my DevStack) - I'll be back for help if I muck up!<br>
<span style="color:rgb(80,0,80)"> </span><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="gmail_extra">
<div class="gmail_quote"><div>
The test failure in the bug you quoted shouldn't be blocking you. You<br><blockquote class="gmail_quote" style="margin:0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;border-right-width:1px;border-right-color:rgb(204,204,204);border-right-style:solid;padding-left:1ex;padding-right:1ex">
</blockquote>might need to ignore it in your own local runs for a bit. That said, the<br><blockquote class="gmail_quote" style="margin:0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;border-right-width:1px;border-right-color:rgb(204,204,204);border-right-style:solid;padding-left:1ex;padding-right:1ex">
</blockquote>patch has supposedly been merged to master so you probably just need to<br>
rebase your patch on master.<br></div></div></div></div></blockquote><font color="#500050"><br></font>There was no test failure, the existing tests have nothing to detect whether the fix for <br> <a href="https://bugs.launchpad.net/nova/+bug/1224453" target="_blank">Bug #1224453 “min_count ignored for instance create” : Bugs : OpenStack Compute (nova)</a><br>
is present or not.<br><br>If some kind soul can guide me on adding unit tests - per my question below - then I'll add them, otherwise I'll just complete the fix for now and add the tests in a later change.<br><br>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">> I'm afraid I really need help now - in particular on how to add a suitable test case.</span><br><span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">> I've been looking at /opt/stack/nova/nova/tests/</span><span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">compute/test_compute_api.py running test_create_quota_</span><span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">exceeded_messages under the debugger to understand how it works to be able to adapt it.</span><br>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">> I'm too inexperienced on this to know how to write a suitable unit test (am I even considering this in the correct file?).</span><br>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px;color:rgb(80,0,80)">> I don't have a good understanding of the current test code and I don't see how I can do quota setting in test_compute_api.py.</span><br>
<br></div>Thanks,<br>Mike.<br><div><div class="gmail_extra"><div class="gmail_quote">
<div><br></div></div></div></div>
</div><br></div></div>
</div></div></div></div></div><br></div>
</div></div></div><br></div>
</div></div></div><br></div>