[openstack-dev] Import ordering for oslo imports

Flavio Percoco flavio at redhat.com
Fri May 31 14:53:13 UTC 2013


On 31/05/13 10:39 -0400, Monty Taylor wrote:
>
>
>On 05/31/2013 10:33 AM, David Ripton wrote:
>> hacking's HACKING.rst says:
>>
>>   {{stdlib imports in human alphabetical order}}
>>   \n
>>   {{third-party lib imports in human alphabetical order}}
>>   \n
>>   {{nova imports in human alphabetical order}}
>>   \n
>>   \n
>>   {{begin your code}}
>>
>> But should oslo imports (in code outside oslo itself) go in the
>> third-party section or the project section?  oslo is kind of both --
>> it's a separate project but it's part of OpenStack, not truly third-party.
>>
>> I've seen it both ways in code I've reviewed lately, and it would be
>> nice to be consistent.
>
>I read "third party" to mean "things from outside of this source tree".
>

+1

-- 
{ name: "Flavio Percoco",
   gpg: "87112EC1",
   internal: "8261386",
   phone: "+390687502386",
   irc: ["fpercoco", "flaper87"]}



More information about the OpenStack-dev mailing list