[openstack-dev] Import ordering for oslo imports

Zhongyue Luo zhongyue.nah at intel.com
Fri May 31 14:43:41 UTC 2013


My understanding is that anything included in requirements.txt
(pip-requires) is thrid party.


On Fri, May 31, 2013 at 10:39 PM, Monty Taylor <mordred at inaugust.com> wrote:

>
>
> On 05/31/2013 10:33 AM, David Ripton wrote:
> > hacking's HACKING.rst says:
> >
> >   {{stdlib imports in human alphabetical order}}
> >   \n
> >   {{third-party lib imports in human alphabetical order}}
> >   \n
> >   {{nova imports in human alphabetical order}}
> >   \n
> >   \n
> >   {{begin your code}}
> >
> > But should oslo imports (in code outside oslo itself) go in the
> > third-party section or the project section?  oslo is kind of both --
> > it's a separate project but it's part of OpenStack, not truly
> third-party.
> >
> > I've seen it both ways in code I've reviewed lately, and it would be
> > nice to be consistent.
>
> I read "third party" to mean "things from outside of this source tree".
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
*Intel SSG/SSD/STO/DCST/CIT*
880 Zixing Road, Zizhu Science Park, Minhang District, 200241, Shanghai,
China
+862161166500
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130531/0dc0d616/attachment.html>


More information about the OpenStack-dev mailing list