Open Stack

So in hacking 0.6 we've current got a proposed change (by me) to have 
hacking have a rule to check that files correctly have the Apache 2 
license header in them. The code landed previously, but was disabled in 
the 0.5.x series with our policy of not adding rules without a non patch 
version bump (https://review.openstack.org/#/c/32461/)

This is *not* the copyright statement issue. The TC ended up without any 
decision at the end of that discussion, so we're just leaving that be 
for now. This is only about whether Apache license stub shows up in code 
files.

The current debate is whether or not this is defined policy. My feeling 
was the results of the TC discussion meant that this was defined policy. 
95%+ of code files currently do this, it ensures that there is no 
ambiguity on the fact that these files are under this license. Various 
interpretations of copyright might say they are not required, but as we 
have, by convention, already basically implemented this policy, I'd like 
to just finish the enforcement in hacking so it's yet another thing we 
don't need to manually review for.

For instance, in the tempest tree, with this catch, we found 4 files 
missing it, and 1 with a typo. Again, representing small percentage of 
files, but some of the newer contributors from organizations that don't 
do much open source have submitted these over time, and it's something 
we need to manually call them on (vs. hacking rejecting them).

I'd like to gather any objections to the check now so we can bring it 
into 0.6. It will be disableable if you don't want to apply it to your 
project, but I think it should be default on in the next major release.

	-Sean

-- 
Sean Dague
http://dague.net