Open Stack

Hi Chris & Rob,


Thanks for your reply ,and sorry for my late response..

- I tested again. The modification won't effect tempest test because it's
an optional argument, so I can commit it later in tempest. Lucky.

- But the bug in Cinder exists at the API layer, so the modification will
effect the CinderClient behavior..  :(

So, that's quite a complex problem.. Any ideas?


wingwj




On Fri, Dec 6, 2013 at 5:41 PM, Lingxian Kong <anlin.kong at gmail.com> wrote:

>
>
> ---------- Forwarded message ----------
> From: Christopher Yeoh <cbkyeoh at gmail.com>
> Date: 2013/12/3
> Subject: Re: [openstack-dev] [OpenStack-dev] How to modify a bug across
> multiple repo?
> To: "OpenStack Development Mailing List (not for usage questions)" <
> openstack-dev at lists.openstack.org>
>
>
> Hi,
>
> On Tue, Dec 3, 2013 at 7:21 PM, Robert Collins <robertc at robertcollins.net>wrote:
>
>> No, you need to manually arrange to land your changes in first one
>> repo then the other.
>>
>> -Rob
>>
>>
>> On 3 December 2013 19:17, wu jiang <wingwj at gmail.com> wrote:
>> > Hi all,
>> >
>> > Recently, I found a bug at API layer in Cinder, but the modifications
>> relate
>> > to CinderClient & Tempest.
>> > So, I'm confused how to commit it. Can 'git --dependence' cross
>> different
>> > Repo?
>>
>
>
> Just to expand on what Rob mentioned - for situations like this its pretty
> common
> not to be able to just say make a change in cinder first because the
> tempest test will
> fail. And at the same time you can't make the final change in tempest
> first because the
> cinder change hasn't applied yet. If this is your situation what I'd
> suggest you do is:
>
> - Submit the cinder change, it will fail tempest, that's ok, you might
> want to leave a comment
> saying you are waiting on a tempest change to land first.
>
> - Submit a tempest change which disables the tempest tests which fail
> because of your change
> and in the commit message reference the gerrit url for the cinder change.
> Its very helpful, but not
> always necessary if you can get a cinder core to +1 this patch so the
> tempest cores know that the
> cinder team is happy with what is going on.
>
> - Once the tempest change has merged, the cinder change should be able to
> merge.
>
> - Submit a tempest change enabling the disabled test(s) and modifying it
> for the expected behaviour.
>
> Yes, it would be nice to be able to have cross project dependent patches :)
>
> Chris
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> *---------------------------------------*
> *Lingxian Kong*
> Huawei Technologies Co.,LTD.
> IT Product Line CloudOS PDU
> China, Xi'an
> Mobile: +86-18602962792
> Email: konglingxian at huawei.com; anlin.kong at gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131211/6aff7512/attachment.html>