<div dir="ltr">Hi Chris & Rob,<div><br></div><div><br></div><div>Thanks for your reply ,and sorry for my late response..</div><div><br></div><div>- I tested again. The modification won't effect tempest test because it's an optional argument, so I can commit it later in tempest. Lucky.</div>
<div><br></div><div>- But the bug in Cinder exists at the API layer, so the modification will effect the CinderClient behavior.. :(</div><div><br></div><div>So, that's quite a <span style="color:rgb(68,68,68);font-family:arial,sans-serif;line-height:16.1200008392334px">complex problem</span>.. Any ideas?</div>
<div><br></div><div><br></div><div>wingwj<br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 6, 2013 at 5:41 PM, Lingxian Kong <span dir="ltr"><<a href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><br><div class="gmail_quote">
---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Christopher Yeoh</b> <span dir="ltr"><<a href="mailto:cbkyeoh@gmail.com" target="_blank">cbkyeoh@gmail.com</a>></span><br>
Date: 2013/12/3<br>Subject: Re: [openstack-dev] [OpenStack-dev] How to modify a bug across multiple repo?<br>To: "OpenStack Development Mailing List (not for usage questions)" <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<br><br><div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote"><div>On Tue, Dec 3, 2013 at 7:21 PM, Robert Collins <span dir="ltr"><<a href="mailto:robertc@robertcollins.net" target="_blank">robertc@robertcollins.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">No, you need to manually arrange to land your changes in first one<br>
repo then the other.<br>
<br>
-Rob<div class="im"><br>
<div><div><br>
On 3 December 2013 19:17, wu jiang <<a href="mailto:wingwj@gmail.com" target="_blank">wingwj@gmail.com</a>> wrote:<br>
> Hi all,<br>
><br>
> Recently, I found a bug at API layer in Cinder, but the modifications relate<br>
> to CinderClient & Tempest.<br>
> So, I'm confused how to commit it. Can 'git --dependence' cross different<br>
> Repo?<br>
</div></div></div></blockquote><div><br><br></div></div><div>Just to expand on what Rob mentioned - for situations like this its pretty common<br></div><div>not to be able to just say make a change in cinder first because the tempest test will<br>
fail. And at the same time you can't make the final change in tempest first because the<br>cinder change hasn't applied yet. If this is your situation what I'd suggest you do is:<br><br></div><div>- Submit the cinder change, it will fail tempest, that's ok, you might want to leave a comment<br>
saying you are waiting on a tempest change to land first.<br></div><div><br>- Submit a tempest change which disables the tempest tests which fail because of your change<br>and in the commit message reference the gerrit url for the cinder change. Its very helpful, but not<br>
always necessary if you can get a cinder core to +1 this patch so the tempest cores know that the<br>cinder team is happy with what is going on.<br></div><div><br></div><div>- Once the tempest change has merged, the cinder change should be able to merge.<br>
<br></div><div>- Submit a tempest change enabling the disabled test(s) and modifying it for the expected behaviour.<br><br></div><div>Yes, it would be nice to be able to have cross project dependent patches :)<br></div><div>
<br></div><div>Chris<br></div><div> <br></div></div></div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><span class="HOEnZb"><font color="#888888"><br>
<br></font></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><b><font color="#000000" style="background-color:rgb(243,243,243)" face="courier new, monospace">---------------------------------------</font></b></div>
<div><font color="#0000ff" face="comic sans ms, sans-serif"><b>Lingxian Kong</b></font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Huawei Technologies Co.,LTD.</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">IT Product Line CloudOS PDU</font></div>
<div><font color="#ff00ff" face="comic sans ms, sans-serif">China, Xi'an</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Mobile: +86-18602962792</font></div><div><font color="#ff00ff" face="comic sans ms, sans-serif">Email: <a href="mailto:konglingxian@huawei.com" target="_blank">konglingxian@huawei.com</a>; <a href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a></font></div>
</div>
</font></span></div>
</blockquote></div><br></div>