Open Stack

On Sun, Aug 18, 2013 at 9:10 PM, Christopher Yeoh <cbkyeoh at gmail.com> wrote:

>
> On Mon, Aug 19, 2013 at 5:51 AM, Robert Collins <robertc at robertcollins.net
> > wrote: - Stable branch maintenance becoming harder.
>
>  The set of proposals being made to tackle this are:
>>  - Set a much harder upper bound on commit size - we were saying 500
>> lines, but the recent research paper suggests that saying 200 lines as
>> target, with rubber band permitting up to 400 lines before we push
>> back really hard.
>>
>
> +1
>
> Though I think we probably could do with some better tools or tool
> improvements
> so we handle reviews of long series of dependent changesets better. As at
> least in my experience, patches
> in a dependent series tend to get reviewed a bit randomly and review
> effort is effectively lost on the later
> changesets when the inevitable rebase is required.
>
> Chris
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
This was pretty well discussed back in April and May IMO.

Suffice it to say, I'm very much against the idea of 'disabled features'
landing in trunk, and I'm also not a fan of the idea of an arbitrary max
lines of code per patch set.  A number of folks have pointed out that we're
getting better at things like "feature-rush" at the end of a cycle and our
own community "best practices" enforcement on patch size.  I think that
model works well in an Open Source environment, particularly one the size
of OpenStack with the varied interest and participation.

IMO intentionally placing non-working (and thereby useless code as far as
I'm concerned) in the project with no testing, no documentation and worst
of all no guarantee that anybody is ever going to work on said code again
is a bad idea.  The explosive growth of what OpenStack is and all of the
projects is pretty difficult for folks to get wrapped around already, let
alone if we start having this unbelievable matrix of flags, paralell
features etc.

Anyway, a number of postings are no longer tracked in this thread it seems,
but there have been statements from Russell B, Thierry and Michael Still
that I strongly agree with here.

By the way for those that want to go back and read the entire thread again
see the archive from April [1]

[1]
http://lists.openstack.org/pipermail/openstack-dev/2013-April/008235.html

Thanks,
John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130818/1e1414a3/attachment.html>