<div dir="ltr"><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 18, 2013 at 9:10 PM, Christopher Yeoh <span dir="ltr"><<a href="mailto:cbkyeoh@gmail.com" target="_blank">cbkyeoh@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<br>On Mon, Aug 19, 2013 at 5:51 AM, Robert Collins <span dir="ltr"><<a href="mailto:robertc@robertcollins.net" target="_blank">robertc@robertcollins.net</a>></span> wrote: - Stable branch maintenance becoming harder.<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
The set of proposals being made to tackle this are:<br>
- Set a much harder upper bound on commit size - we were saying 500<br>
lines, but the recent research paper suggests that saying 200 lines as<br>
target, with rubber band permitting up to 400 lines before we push<br>
back really hard.<br></blockquote><div><br></div></div><div>+1 <br><br>Though I think we probably could do with some better tools or tool improvements <br>so we handle reviews of long series of dependent changesets better. As at least in my experience, patches<br>
</div><div>in a dependent series tend to get reviewed a bit randomly and review effort is effectively lost on the later<br></div><div>changesets when the inevitable rebase is required.<br></div><div> <br></div><div>Chris<br>
</div></div></div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">This was pretty well discussed back in April and May IMO.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">Suffice it to say, I'm very much against the idea of 'disabled features' landing in trunk, and I'm also not a fan of the idea of an arbitrary max lines of code per patch set. A number of folks have pointed out that we're getting better at things like "feature-rush" at the end of a cycle and our own community "best practices" enforcement on patch size. I think that model works well in an Open Source environment, particularly one the size of OpenStack with the varied interest and participation.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">IMO intentionally placing non-working (and thereby useless code as far as I'm concerned) in the project with no testing, no documentation and worst of all no guarantee that anybody is ever going to work on said code again is a bad idea. The explosive growth of what OpenStack is and all of the projects is pretty difficult for folks to get wrapped around already, let alone if we start having this unbelievable matrix of flags, paralell features etc.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">Anyway, a number of postings are no longer tracked in this thread it seems, but there have been statements from Russell B, Thierry and Michael Still that I strongly agree with here.</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">By the way for those that want to go back and read the entire thread again see the archive from April [1]</div>
<div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">[1] <a href="http://lists.openstack.org/pipermail/openstack-dev/2013-April/008235.html" style="font-family:arial">http://lists.openstack.org/pipermail/openstack-dev/2013-April/008235.html</a><br>
</div><div class="gmail_default" style="font-family:'courier new',monospace"><br></div><div class="gmail_default" style="font-family:'courier new',monospace">Thanks,</div><div class="gmail_default" style="font-family:'courier new',monospace">
John</div></div></div>