Open Stack

On Mon, Apr 29, 2013 at 10:29 AM, Mark McLoughlin <markmc at redhat.com> wrote:

> On Mon, 2013-04-29 at 09:45 -0400, Eric Windisch wrote:
> > >
> > > It was, originally, but create_worker() uses the RPC dispatcher so we
> had to change. Now that we have join_consumer_pool() in the public API, we
> could change back.
> > >
> >
> >
> > Is create_worker not used in Ceilometer anymore? This was added for
> > Ceilometer's benefit. If it isn't used, we might want to deprecate it.
>
> It is used to listen on the 'metering' topic ... but I'm not entirely
> sure why.
>
>         # Set ourselves up as a separate worker for the metering data,
>         # since the default for service is to use create_consumer().
>         self.conn.create_worker(
>             cfg.CONF.metering_topic,
>             rpc_dispatcher.RpcDispatcher([self]),
>             'ceilometer.collector.' + cfg.CONF.metering_topic,
>         )
>
> The best guess I can come up for this is that we want to use a
> non-default worker pool so that third party listeners can use the
> default worker pool.
>

If I had written join_consumer_pool() before create_worker() I would never
have needed create_worker(). I'd like to wait for the new rpc API to come
out before changing ceilometer, but I think we can assume create_worker()
could go away.

Doug


>
> Cheers,
> Mark.
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130429/9dae4fbf/attachment.html>