[openstack-dev] core contributor vs reviewer (was: [keystone] Proposal to add Andy Smith to keystone core)

Mark McLoughlin markmc at redhat.com
Mon Apr 22 19:57:57 UTC 2013


On Mon, 2013-04-22 at 11:04 -0700, Dolph Mathews wrote:
> Ultimately, "core contributor" to me simply means that this person's
> downvotes on code reviews are consistently well thought out and meaningful,
> such that an upvote by the same person shows a lot of confidence in the
> patch.

That's a nice way of expressing what makes a good reviewer

Cheers,
Mark.




More information about the OpenStack-dev mailing list