[openstack-dev] When to use openstack-common

Mark McLoughlin markmc at redhat.com
Mon Sep 10 07:04:04 UTC 2012

Hi Gabriel,

On Fri, 2012-09-07 at 19:09 +0000, Gabriel Hurley wrote:
> In response to https://review.openstack.org/#/c/12413/ I'm faced with
> the following question: should openstack common modules be included in
> cases where they're not providing any benefit other than
> standardization?
> In particular, there are 3 points around that review:
>   1. The jsonutils code is designed to solve problems Horizon doesn't
> have.

How come it was imported in the first place?

>   2. The timeutils code duplicates functionality already built into
> Django (which Horizon is built on) and is only included because
> jsonutils now requires it.
>   3. The timeutils code is now adding external dependencies (iso8601
> python module) which *again* is duplicating built-in function in
> Django.

IMHO, this all sounds like perfectly good rationale to not use

If you really wanted to use jsonutils but wanted to avoid timeutils, I'm
sure we could figure something out, but it sounds like that's not the


More information about the OpenStack-dev mailing list