[openstack-dev] Pep8 versions??

Chuck Short chuck.short at canonical.com
Tue Nov 20 00:16:22 UTC 2012


On 12-11-19 06:40 PM, Joe Gordon wrote:
>
>
> On Mon, Nov 19, 2012 at 3:06 PM, Monty Taylor <mordred at inaugust.com 
> <mailto:mordred at inaugust.com>> wrote:
>
>     I think these are orthogonal. In general I believe we're in
>     agreement that we should be targetting the same version of pep8,
>     and that we should pin that version early in the cycle. However we
>     install that version of pep8 is a different argument.
>
>
> Targeting the same version of pep8 is only part of the problem, we 
> would also need to agree on what rules to ignore. For example:
>
> glance (pep8 1.3.3) ignores: E125,E126,E711,E712
> nova (pep8 1.2) ignores: E12,E711,E721
> keystone (pep8 1.3.3) ignores: ---

Is there a reason why these were ignored?
>
>
>
>     On 11/19/2012 02:44 PM, Joshua Harlow wrote:
>
>         I'm not sure I agree with the solution (aka use tox/venv) that
>         keeps on
>         postponing/avoiding the underlying problem :-)
>
>         From: Endre Karlson <endre.karlson at gmail.com
>         <mailto:endre.karlson at gmail.com>
>         <mailto:endre.karlson at gmail.com
>         <mailto:endre.karlson at gmail.com>>>
>
>         Reply-To: OpenStack Development Mailing List
>         <openstack-dev at lists.openstack.org
>         <mailto:openstack-dev at lists.openstack.org>
>         <mailto:openstack-dev at lists.openstack.org
>         <mailto:openstack-dev at lists.openstack.org>>>
>
>         Date: Monday, November 19, 2012 2:39 PM
>         To: OpenStack Development Mailing List
>         <openstack-dev at lists.openstack.org
>         <mailto:openstack-dev at lists.openstack.org>
>         <mailto:openstack-dev at lists.openstack.org
>         <mailto:openstack-dev at lists.openstack.org>>>
>
>         Subject: Re: [openstack-dev] Pep8 versions??
>
>         Tox?
>
>         Den 19. nov. 2012 23:12 skrev "Joshua Harlow"
>         <harlowja at yahoo-inc.com <mailto:harlowja at yahoo-inc.com>
>         <mailto:harlowja at yahoo-inc.com
>         <mailto:harlowja at yahoo-inc.com>>> følgende:
>
>
>         Hi all,
>
>         I was wondering if the community has not yet finalized on
>         which pep8
>         version will be common to all subprojects.
>
>         I am seeing this:
>
>         Nova -> pep8==1.2
>         Keystone -> pep8==1.3.3
>         Glance -> pep8==1.3.3
>         Horizon -> pep8>=1.3
>
>         Is there work underway to move nova to 1.3.3 (and resolve the new
>         pep8 complaints?).
>
>         Random thoughts:
>         1. Perhaps the dependency shouldn't be updated to 1.3.3 until all
>         code is complaint (across all projects)?? (1.3 new checks
>         should not
>         cause 1.2 issues right??)
>         2. From a packaging/packagers perspective having this makes it
>         very
>         hard to know which one will and will not work (especially when
>         installing/testing/running on a single machine)…
>
>         Thanks,
>         Josh
>
>         _______________________________________________
>         OpenStack-dev mailing list
>         OpenStack-dev at lists.openstack.org
>         <mailto:OpenStack-dev at lists.openstack.org>
>         <mailto:OpenStack-dev at lists.openstack.org
>         <mailto:OpenStack-dev at lists.openstack.org>>
>         http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
>         _______________________________________________
>         OpenStack-dev mailing list
>         OpenStack-dev at lists.openstack.org
>         <mailto:OpenStack-dev at lists.openstack.org>
>         http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>     _______________________________________________
>     OpenStack-dev mailing list
>     OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




More information about the OpenStack-dev mailing list