Open Stack

Agree; I discovered the same thing when one of my patches failed to merge
to stable/folsom: https://review.openstack.org/#/c/18049/

Should we temporarily revert the patch that introduced the dependency on
'requests' until we work out the test infrastructure?
https://review.openstack.org/#/c/18621/


-Dolph


On Mon, Dec 24, 2012 at 11:47 AM, James E. Blair <corvus at inaugust.com>wrote:

> OpenStack Jenkins  <jenkins at openstack.org> writes:
>
> > See <
> https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/84/
> >
> >
> > ------------------------------------------
> > [...truncated 4953 lines...]
> >     from keystoneclient import client
> >   File "<
> https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/ws/vendor/python-keystoneclient-master/keystoneclient/client.py",>
> line 16, in <module>
> >     import requests
> > ImportError: No module named requests
> ...
> > + .tox/py27/bin/pip freeze
> > Babel==0.9.6
> > Jinja2==2.6
> > Paste==1.7.5.1
> > PasteDeploy==1.5.0
> > Pygments==1.5
> > Routes==1.13
> > SQLAlchemy==0.7.9
> > Sphinx==1.1.3
> > Tempita==0.5.1
> > WebOb==1.0.8
> > WebTest==1.4.3
> > argparse==1.2.1
> > colorama==0.2.4
> > coverage==3.6b1
> > decorator==3.4.0
> > distribute==0.6.31
> > docutils==0.10
> > eventlet==0.9.17
> > greenlet==0.4.0
> > httplib2==0.7.7
> > iso8601==0.1.4
> > keystone==2012.2.3
> > logilab-astng==0.24.1
> > logilab-common==0.58.3
> > lxml==3.1beta1
> > mox==0.5.3
> > netifaces==0.8
> > nose==1.2.1
> > nosehtmloutput==0.0.4
> > nosexcover==1.0.7
> > openstack.nose-plugin==0.11
> > pam==0.1.4
> > passlib==1.6.1
> > pep8==1.3.3
> > prettytable==0.6.1
> > pylint==0.26.0
> > python-keystoneclient==0.1.3
> > python-ldap==2.3.13
> > python-memcached==1.48
> > python-swiftclient==1.2.0
> > repoze.lru==0.6
> > simplejson==2.6.2
> > sqlalchemy-migrate==0.7.2
> > swift==1.7.6
> > termcolor==1.1.0
> > unittest2==0.5.1
> > wsgiref==0.1.2
> > xattr==0.6.4
>
> I looked into this, and I believe the problem is that in this file:
>
>
> https://github.com/openstack/keystone/blob/stable/folsom/tests/test_keystoneclient.py
>
> It checks out python-keystoneclient git repos from gerrit into the
> keystone workspace and attempts tests with different branches.  The
> problem is that different versions of python-keystoneclient will have
> different dependencies, and since they are not being installed properly
> with setuptools, those dependencies will not be in the environment.  In
> this case, 'requests', which is a current dependency of keystoneclient,
> is not available.
>
> In general, I don't think _inside_ the test cases is a good place to be
> installing software.  This might be more appropriate as a set of jenkins
> jobs and tox configs that install the needed dependencies before running
> tests.
>
> -Jim
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20121224/0c6a000a/attachment.html>