<div dir="ltr">Agree; I discovered the same thing when one of my patches failed to merge to stable/folsom: <a href="https://review.openstack.org/#/c/18049/">https://review.openstack.org/#/c/18049/</a><div><br></div><div style>
Should we temporarily revert the patch that introduced the dependency on 'requests' until we work out the test infrastructure? <a href="https://review.openstack.org/#/c/18621/">https://review.openstack.org/#/c/18621/</a></div>
</div><div class="gmail_extra"><br clear="all"><div><div><br></div>-Dolph</div>
<br><br><div class="gmail_quote">On Mon, Dec 24, 2012 at 11:47 AM, James E. Blair <span dir="ltr"><<a href="mailto:corvus@inaugust.com" target="_blank">corvus@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
OpenStack Jenkins  <<a href="mailto:jenkins@openstack.org">jenkins@openstack.org</a>> writes:<br>
<br>
> See <<a href="https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/84/" target="_blank">https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/84/</a>><br>
><br>
> ------------------------------------------<br>
> [...truncated 4953 lines...]<br>
>     from keystoneclient import client<br>
>   File "<<a href="https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/ws/vendor/python-keystoneclient-master/keystoneclient/client.py" target="_blank">https://jenkins.openstack.org/job/periodic-keystone-python27-stable-folsom/ws/vendor/python-keystoneclient-master/keystoneclient/client.py</a>",> line 16, in <module><br>

>     import requests<br>
> ImportError: No module named requests<br>
...<br>
> + .tox/py27/bin/pip freeze<br>
> Babel==0.9.6<br>
> Jinja2==2.6<br>
> Paste==1.7.5.1<br>
> PasteDeploy==1.5.0<br>
> Pygments==1.5<br>
> Routes==1.13<br>
> SQLAlchemy==0.7.9<br>
> Sphinx==1.1.3<br>
> Tempita==0.5.1<br>
> WebOb==1.0.8<br>
> WebTest==1.4.3<br>
> argparse==1.2.1<br>
> colorama==0.2.4<br>
> coverage==3.6b1<br>
> decorator==3.4.0<br>
> distribute==0.6.31<br>
> docutils==0.10<br>
> eventlet==0.9.17<br>
> greenlet==0.4.0<br>
> httplib2==0.7.7<br>
> iso8601==0.1.4<br>
> keystone==2012.2.3<br>
> logilab-astng==0.24.1<br>
> logilab-common==0.58.3<br>
> lxml==3.1beta1<br>
> mox==0.5.3<br>
> netifaces==0.8<br>
> nose==1.2.1<br>
> nosehtmloutput==0.0.4<br>
> nosexcover==1.0.7<br>
> openstack.nose-plugin==0.11<br>
> pam==0.1.4<br>
> passlib==1.6.1<br>
> pep8==1.3.3<br>
> prettytable==0.6.1<br>
> pylint==0.26.0<br>
> python-keystoneclient==0.1.3<br>
> python-ldap==2.3.13<br>
> python-memcached==1.48<br>
> python-swiftclient==1.2.0<br>
> repoze.lru==0.6<br>
> simplejson==2.6.2<br>
> sqlalchemy-migrate==0.7.2<br>
> swift==1.7.6<br>
> termcolor==1.1.0<br>
> unittest2==0.5.1<br>
> wsgiref==0.1.2<br>
> xattr==0.6.4<br>
<br>
I looked into this, and I believe the problem is that in this file:<br>
<br>
<a href="https://github.com/openstack/keystone/blob/stable/folsom/tests/test_keystoneclient.py" target="_blank">https://github.com/openstack/keystone/blob/stable/folsom/tests/test_keystoneclient.py</a><br>
<br>
It checks out python-keystoneclient git repos from gerrit into the<br>
keystone workspace and attempts tests with different branches.  The<br>
problem is that different versions of python-keystoneclient will have<br>
different dependencies, and since they are not being installed properly<br>
with setuptools, those dependencies will not be in the environment.  In<br>
this case, 'requests', which is a current dependency of keystoneclient,<br>
is not available.<br>
<br>
In general, I don't think _inside_ the test cases is a good place to be<br>
installing software.  This might be more appropriate as a set of jenkins<br>
jobs and tox configs that install the needed dependencies before running<br>
tests.<br>
<br>
-Jim<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>