[all][qinling] Please check your README files
Train cycle is supposed to be "we really go for Python 3" cycle. Contrary to previous "we do not have to care about Python 3" ones.
I am working on switching Kolla images into Python 3 by default [1]. It is a job I would not recommend even to my potential enemies. Misc projects fail into random ways (sent a bunch of patches).
1. https://review.opendev.org/#/c/642375
Quite common issue is related to README files. I know that we have XXI century and UTF-8 is encoding for most of people here. But Python tools are not so advanced so far and loves to explode when see characters outside of US-ASCII encoding.
Please check your README files. And move them to US-ASCII if needed.
I already fixed few projects [2][3][4][5] but would love to see developers fixing their code too.
2. https://review.opendev.org/644531 3. https://review.opendev.org/644533 4. https://review.opendev.org/644535 5. https://review.opendev.org/644536
On 5/23/19 8:27 AM, Marcin Juszkiewicz wrote:
Train cycle is supposed to be "we really go for Python 3" cycle. Contrary to previous "we do not have to care about Python 3" ones.
I am working on switching Kolla images into Python 3 by default [1]. It is a job I would not recommend even to my potential enemies. Misc projects fail into random ways (sent a bunch of patches).
Quite common issue is related to README files. I know that we have XXI century and UTF-8 is encoding for most of people here. But Python tools are not so advanced so far and loves to explode when see characters outside of US-ASCII encoding.
Hmm, is this because of https://bugs.launchpad.net/pbr/+bug/1704472 ?
If so, we should just fix it in pbr. I have a patch up to do that (https://review.opendev.org/#/c/564874) but I haven't gotten around to writing tests for it. I'll try to get that done shortly.
Please check your README files. And move them to US-ASCII if needed.
I already fixed few projects [2][3][4][5] but would love to see developers fixing their code too.
W dniu 23.05.2019 o 15:50, Ben Nemec pisze:
On 5/23/19 8:27 AM, Marcin Juszkiewicz wrote:
Quite common issue is related to README files. I know that we have XXI century and UTF-8 is encoding for most of people here. But Python tools are not so advanced so far and loves to explode when see characters outside of US-ASCII encoding.
Hmm, is this because of https://bugs.launchpad.net/pbr/+bug/1704472 ?
If so, we should just fix it in pbr. I have a patch up to do that (https://review.opendev.org/#/c/564874) but I haven't gotten around to writing tests for it. I'll try to get that done shortly.
Thanks!
I did not digged in whole stack as there were several other things to debug.
W dniu 23.05.2019 o 15:50, Ben Nemec pisze:
Hmm, is this because of https://bugs.launchpad.net/pbr/+bug/1704472 ?
If so, we should just fix it in pbr. I have a patch up to do that (https://review.opendev.org/#/c/564874) but I haven't gotten around to writing tests for it. I'll try to get that done shortly.
I provided better description example for that patch. Based on changes done in some projects.
u'UTF-8 description can contain misc Unicode “quotes”, ’apostrophes’, multiple dots like “…“, misc dashes like “–“ for example. Some projects also use IPA to show pronounciation of their name so chars like ”ʃŋ” can happen.'
On 5/24/19 3:20 AM, Marcin Juszkiewicz wrote:
W dniu 23.05.2019 o 15:50, Ben Nemec pisze:
Hmm, is this because of https://bugs.launchpad.net/pbr/+bug/1704472 ?
If so, we should just fix it in pbr. I have a patch up to do that (https://review.opendev.org/#/c/564874) but I haven't gotten around to writing tests for it. I'll try to get that done shortly.
I provided better description example for that patch. Based on changes done in some projects.
u'UTF-8 description can contain misc Unicode “quotes”, ’apostrophes’, multiple dots like “…“, misc dashes like “–“ for example. Some projects also use IPA to show pronounciation of their name so chars like ”ʃŋ” can happen.'
Okay, the fix for this should be available in pbr 5.3.0. If everyone who was affected by this bug could verify 5.3.0 fixes the problem that would be great!
Thanks.
-Ben
Thanks for the reminder, Marcin. Qinling issue should be fixed in https://review.opendev.org/#/c/661005 (Tip hat to Gaëtan Trellu!)
--- Best regards, Lingxian Kong Catalyst Cloud
On Fri, May 24, 2019 at 1:35 AM Marcin Juszkiewicz < marcin.juszkiewicz@linaro.org> wrote:
Train cycle is supposed to be "we really go for Python 3" cycle. Contrary to previous "we do not have to care about Python 3" ones.
I am working on switching Kolla images into Python 3 by default [1]. It is a job I would not recommend even to my potential enemies. Misc projects fail into random ways (sent a bunch of patches).
Quite common issue is related to README files. I know that we have XXI century and UTF-8 is encoding for most of people here. But Python tools are not so advanced so far and loves to explode when see characters outside of US-ASCII encoding.
Please check your README files. And move them to US-ASCII if needed.
I already fixed few projects [2][3][4][5] but would love to see developers fixing their code too.
W dniu 24.05.2019 o 00:23, Lingxian Kong pisze:
Thanks for the reminder, Marcin. Qinling issue should be fixed in https://review.opendev.org/#/c/661005 (Tip hat to Gaëtan Trellu!)
Thanks!
I hope that PBR issue gets fixes soon, then openstack/requirements gets PBR version bump so we can revert that change to show IPA characters again.
Le ven. 24 mai 2019 à 10:26, Marcin Juszkiewicz < marcin.juszkiewicz@linaro.org> a écrit :
W dniu 24.05.2019 o 00:23, Lingxian Kong pisze:
Thanks for the reminder, Marcin. Qinling issue should be fixed in https://review.opendev.org/#/c/661005 (Tip hat to Gaëtan Trellu!)
Thanks!
I hope that PBR issue gets fixes soon, then openstack/requirements gets PBR version bump so we can revert that change to show IPA characters again.
Hello,
I've added some changes related to your comments to tests more characters who need UTF8.
On 2019-05-24 10:19:49 +0200 (+0200), Marcin Juszkiewicz wrote: [...]
I hope that PBR issue gets fixes soon, then openstack/requirements gets PBR version bump so we can revert that change to show IPA characters again.
The PBR constraint in global requirements is really only used in places like integration testing environments where it's explicitly preinstalled. For situations where it gets pulled in by setuptools (which is most times where a job pip installs a project using it), all that really matters is what the latest version allowed by the setup_requires list argument to the setuptools.setup() function call in its setup.py file is. That call never gets constrained anyway.
participants (5)
-
Ben Nemec
-
Herve Beraud
-
Jeremy Stanley
-
Lingxian Kong
-
Marcin Juszkiewicz