[tripleo][kolla][osa][nova][deployment] Removing nova-consoleauth
In my continued efforts to remove as much nova code as possible in one cycle, I've set my sights on the 'nova-consoleauth' service. Since Rocky [1], 'nova-consoleauth' is no longer needed and we now store and retrieve tokens from the database. The only reason to still deploy 'nova-consoleauth' was to support cells v1 or to provide a window where existing tokens could continue to be validated before everything switched over to the new model, but we're also in the process of removing cells v1 [2] and two cycles in quite a large window in which to migrate things. I've the work done from the nova side but before we can merge anything, we need to remove support for nova-consoleauth from the various deployment projects and anything else that relies on it at the moment. I have talked to some folks internally about doing this in TripleO this cycle and I have a (likely wrong) patch proposed against Kolla [3] for this, but I haven't been able to figure out how/if OSA are deploying the service and would appreciate some help here. I'd also like it if people could let me know if there are any other potential blockers out there that we should be aware of before we proceed with this. Cheers, Stephen [1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con... [2] https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/ [3] https://review.opendev.org/#/c/661251/
Hi, OSA already dropped the 'nova-consoleauth' service with this patch [1]. It was also backported to stein, so since rocky we do not deploy it anymore. But still thanks for the notification. [1] https://review.opendev.org/#/c/649202/ 24.05.2019, 14:16, "Stephen Finucane" <sfinucan@redhat.com>:
In my continued efforts to remove as much nova code as possible in one cycle, I've set my sights on the 'nova-consoleauth' service. Since Rocky [1], 'nova-consoleauth' is no longer needed and we now store and retrieve tokens from the database. The only reason to still deploy 'nova-consoleauth' was to support cells v1 or to provide a window where existing tokens could continue to be validated before everything switched over to the new model, but we're also in the process of removing cells v1 [2] and two cycles in quite a large window in which to migrate things.
I've the work done from the nova side but before we can merge anything, we need to remove support for nova-consoleauth from the various deployment projects and anything else that relies on it at the moment. I have talked to some folks internally about doing this in TripleO this cycle and I have a (likely wrong) patch proposed against Kolla [3] for this, but I haven't been able to figure out how/if OSA are deploying the service and would appreciate some help here. I'd also like it if people could let me know if there are any other potential blockers out there that we should be aware of before we proceed with this.
Cheers, Stephen
[1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con... [2] https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/ [3] https://review.opendev.org/#/c/661251/
-- Kind Regards, Dmitriy Rabotyagov
Thanks to @Martin Schuppert <mschuppert@redhat.com> , the work has been done in TripleO. On Fri, May 24, 2019 at 7:51 AM Dmitriy Rabotyagov <noonedeadpunk@ya.ru> wrote:
Hi,
OSA already dropped the 'nova-consoleauth' service with this patch [1]. It was also backported to stein, so since rocky we do not deploy it anymore.
But still thanks for the notification.
[1] https://review.opendev.org/#/c/649202/
24.05.2019, 14:16, "Stephen Finucane" <sfinucan@redhat.com>:
In my continued efforts to remove as much nova code as possible in one cycle, I've set my sights on the 'nova-consoleauth' service. Since Rocky [1], 'nova-consoleauth' is no longer needed and we now store and retrieve tokens from the database. The only reason to still deploy 'nova-consoleauth' was to support cells v1 or to provide a window where existing tokens could continue to be validated before everything switched over to the new model, but we're also in the process of removing cells v1 [2] and two cycles in quite a large window in which to migrate things.
I've the work done from the nova side but before we can merge anything, we need to remove support for nova-consoleauth from the various deployment projects and anything else that relies on it at the moment. I have talked to some folks internally about doing this in TripleO this cycle and I have a (likely wrong) patch proposed against Kolla [3] for this, but I haven't been able to figure out how/if OSA are deploying the service and would appreciate some help here. I'd also like it if people could let me know if there are any other potential blockers out there that we should be aware of before we proceed with this.
Cheers, Stephen
[1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con... [2] https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/ [3] https://review.opendev.org/#/c/661251/
-- Kind Regards, Dmitriy Rabotyagov
-- Emilien Macchi
Hello, Seems like we have missed deprecating this behavior in Puppet OpenStack in Stein. I've pushed two patches to have the functionality removed and classes/params deprecated as per our process [1]. I haven't researched further if any more action is required, so please let me know if something needs to be added. Best regards [1] https://review.opendev.org/#/q/topic:deprecate-consoleauth On 05/24/2019 02:04 PM, Emilien Macchi wrote:
Thanks to @Martin Schuppert <mailto:mschuppert@redhat.com> , the work has been done in TripleO.
On Fri, May 24, 2019 at 7:51 AM Dmitriy Rabotyagov <noonedeadpunk@ya.ru <mailto:noonedeadpunk@ya.ru>> wrote:
Hi,
OSA already dropped the 'nova-consoleauth' service with this patch [1]. It was also backported to stein, so since rocky we do not deploy it anymore.
But still thanks for the notification.
[1] https://review.opendev.org/#/c/649202/ <https://review.opendev.org/#/c/649202/>
24.05.2019, 14:16, "Stephen Finucane" <sfinucan@redhat.com <mailto:sfinucan@redhat.com>>: > In my continued efforts to remove as much nova code as possible in one > cycle, I've set my sights on the 'nova-consoleauth' service. Since > Rocky [1], 'nova-consoleauth' is no longer needed and we now store and > retrieve tokens from the database. The only reason to still deploy > 'nova-consoleauth' was to support cells v1 or to provide a window where > existing tokens could continue to be validated before everything > switched over to the new model, but we're also in the process of > removing cells v1 [2] and two cycles in quite a large window in which > to migrate things. > > I've the work done from the nova side but before we can merge anything, > we need to remove support for nova-consoleauth from the various > deployment projects and anything else that relies on it at the moment. > I have talked to some folks internally about doing this in TripleO this > cycle and I have a (likely wrong) patch proposed against Kolla [3] for > this, but I haven't been able to figure out how/if OSA are deploying > the service and would appreciate some help here. I'd also like it if > people could let me know if there are any other potential blockers out > there that we should be aware of before we proceed with this. > > Cheers, > Stephen > > [1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con... > [2] https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/ <https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/> > [3] https://review.opendev.org/#/c/661251/ <https://review.opendev.org/#/c/661251/>
-- Kind Regards, Dmitriy Rabotyagov
-- Emilien Macchi
Thanks for the replies, all. Looks like we're in pretty good shape to proceed with the removal this cycle. I've since drafted patches to deprecate the service in RDO/OSP too [1]. Other distros should probably do the same at some point in the next few weeks. Stephen [1] https://review.rdoproject.org/r/20922 On Fri, 2019-05-24 at 14:22 +0200, Tobias Urdin wrote:
Hello,
Seems like we have missed deprecating this behavior in Puppet OpenStack in Stein.
I've pushed two patches to have the functionality removed and classes/params deprecated as per our process [1].
I haven't researched further if any more action is required, so please let me know if something needs to be added.
Best regards
[1] https://review.opendev.org/#/q/topic:deprecate-consoleauth
On 05/24/2019 02:04 PM, Emilien Macchi wrote:
Thanks to @Martin Schuppert , the work has been done in TripleO.
On Fri, May 24, 2019 at 7:51 AM Dmitriy Rabotyagov <noonedeadpunk@ya.ru> wrote:
Hi,
OSA already dropped the 'nova-consoleauth' service with this patch [1].
It was also backported to stein, so since rocky we do not deploy it anymore.
But still thanks for the notification.
[1] https://review.opendev.org/#/c/649202/
24.05.2019, 14:16, "Stephen Finucane" < sfinucan@redhat.com>:
> In my continued efforts to remove as much nova code as possible in one
> cycle, I've set my sights on the 'nova-consoleauth' service. Since
> Rocky [1], 'nova-consoleauth' is no longer needed and we now store and
> retrieve tokens from the database. The only reason to still deploy
> 'nova-consoleauth' was to support cells v1 or to provide a window where
> existing tokens could continue to be validated before everything
> switched over to the new model, but we're also in the process of
> removing cells v1 [2] and two cycles in quite a large window in which
> to migrate things.
>
> I've the work done from the nova side but before we can merge anything,
> we need to remove support for nova-consoleauth from the various
> deployment projects and anything else that relies on it at the moment.
> I have talked to some folks internally about doing this in TripleO this
> cycle and I have a (likely wrong) patch proposed against Kolla [3] for
> this, but I haven't been able to figure out how/if OSA are deploying
> the service and would appreciate some help here. I'd also like it if
> people could let me know if there are any other potential blockers out
> there that we should be aware of before we proceed with this.
>
> Cheers,
> Stephen
>
> [1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con...
> [2]
https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/
> [3] https://review.opendev.org/#/c/661251/
--
Kind Regards,
Dmitriy Rabotyagov
--
Emilien Macchi
On 5/24/2019 7:22 AM, Tobias Urdin wrote:
Seems like we have missed deprecating this behavior in Puppet OpenStack in Stein. I've pushed two patches to have the functionality removed and classes/params deprecated as per our process [1].
I haven't researched further if any more action is required, so please let me know if something needs to be added.
A check was added to "nova-status upgrade check" in Stein (and backported to Rocky) [1] so I don't know if you're running those upgrade checks but that could be potentially useful during an upgrade, but at the same time if you're just not deploying the service anymore (in Train?) then I'm not sure how useful it would be. [1] https://review.opendev.org/#/c/611214/ -- Thanks, Matt
Hi Stephen, Thanks for the patch in Kolla side. But we need remove the code in kolla-ansible at first, then remove kolla image. Otherwise, kolla-ansible CI will be busted. I pushed the kolla-ansible side patch[1]. Could you add a Depends-On for your patch? Thanks, Jeffrey4l [1] https://review.opendev.org/#/c/661427/ On Fri, May 24, 2019 at 7:14 PM Stephen Finucane <sfinucan@redhat.com> wrote:
In my continued efforts to remove as much nova code as possible in one cycle, I've set my sights on the 'nova-consoleauth' service. Since Rocky [1], 'nova-consoleauth' is no longer needed and we now store and retrieve tokens from the database. The only reason to still deploy 'nova-consoleauth' was to support cells v1 or to provide a window where existing tokens could continue to be validated before everything switched over to the new model, but we're also in the process of removing cells v1 [2] and two cycles in quite a large window in which to migrate things.
I've the work done from the nova side but before we can merge anything, we need to remove support for nova-consoleauth from the various deployment projects and anything else that relies on it at the moment. I have talked to some folks internally about doing this in TripleO this cycle and I have a (likely wrong) patch proposed against Kolla [3] for this, but I haven't been able to figure out how/if OSA are deploying the service and would appreciate some help here. I'd also like it if people could let me know if there are any other potential blockers out there that we should be aware of before we proceed with this.
Cheers, Stephen
[1] https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/con... [2] https://blueprints.launchpad.net/nova/+spec/remove-cells-v1/ [3] https://review.opendev.org/#/c/661251/
participants (6)
-
Dmitriy Rabotyagov
-
Emilien Macchi
-
Jeffrey Zhang
-
Matt Riedemann
-
Stephen Finucane
-
Tobias Urdin