Open Stack

----- Original Message -----
> From: "Christian Berendt" <christian at berendt.io>
> To: "Steve Gordon" <sgordon at redhat.com>
> 
> On 01/26/2016 04:41 PM, Steve Gordon wrote:
> > I have been following the review since it was first proposed in October and
> > have largely agreed with the comments posted. The comments on the most
> > recent patchsets appeared to have been actioned.
> 
> You reviewed it 2 times, because of that I assumed that you take care of
> it since January.
> 
> > Christian, you yourself gave it a +2 without any associated comment - it
> > seems a bit rich to then wonder why it was merged. The comment you refer
> > to was a week ago 4 patch-sets and further comments from Matt prior, if
> > you don't want something to merge then explicitly mark it WIP using the
> > workflow flag and/or submit a negative vote, that is what these features
> > are for.
> 
>  From my site it is fine to merge the patch as-is and to improve it in
> follow-up patches (like we are doing it right now), because of that I
> gave my +2. It is not te point that the review request is now merged.
> 
> The WIP flag is removed after each new patch set, same with the -1. It
> is a hassle to WIP/-1 a review quest after every new patch set.

It is nonetheless what it is for, and you voted on the latest patchset in question and had the opportunity to set it. I don't see how it is more of a hassle when you are already in the voting screen...

> When I note that Matt should make the final review and merge it
> afterwards I do not withdrawl this comment in an other comment I do not
> understand why my comment should be deprecated today.

I didn't see your note on patchset 31 as I was reviewing patchset 34, the *current* patchset I did however see your +2 with no associated comment - gain on the *current* patchset. That again is why using WIP or at least making a comment associated with your latest vote is important if you don't in fact intend it to merge. The default for +2 is "Looks good to me", not "Looks good to me but XYZ".

-Steve