[openstack-dev] [tc][all] A culture change (nitpicking)
amy at demarco.com
Tue May 29 15:35:09 UTC 2018
If I have a nit that doesn't affect things, I'll make a note of it and say
if you do another patch I'd really like it fixed but also give the patch a
vote. What I'll also do sometimes if I know the user or they are online
I'll offer to fix things for them, that way they can see what I've done,
I've sped things along and I haven't caused a simple change to take a long
amount of time and reviews.
I think this is a great addition!
On Tue, May 29, 2018 at 6:55 AM, Julia Kreger <juliaashleykreger at gmail.com>
> During the Forum, the topic of review culture came up in session after
> session. During these discussions, the subject of our use of nitpicks
> were often raised as a point of contention and frustration, especially
> by community members that have left the community and that were
> attempting to re-engage the community. Contributors raised the point
> of review feedback requiring for extremely precise English, or
> compliance to a particular core reviewer's style preferences, which
> may not be the same as another core reviewer.
> These things are not just frustrating, but also very inhibiting for
> part time contributors such as students who may also be time limited.
> Or an operator who noticed something that was clearly a bug and that
> put forth a very minor fix and doesn't have the time to revise it over
> and over.
> While nitpicks do help guide and teach, the consensus seemed to be
> that we do need to shift the culture a little bit. As such, I've
> proposed a change to our principles in governance that attempts to
> capture the essence and spirit of the nitpicking topic as a first
> : https://review.openstack.org/570940
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev