[openstack-dev] [tc][all] A culture change (nitpicking)

Jay S Bryant jungleboyj at gmail.com
Tue May 29 18:29:02 UTC 2018


Thank you for starting this discussion.

On 5/29/2018 9:43 AM, Artom Lifshitz wrote:
> I dunno, there's a fine line to be drawn between getting a finished
> product that looks unprofessional (because of typos, English mistakes,
> etc), and nitpicking to the point of smothering and being
> counter-productive. One idea would be that, once the meat of the patch
> has passed multiple rounds of reviews and looks good, and what remains
> is only nits, the reviewer themselves take on the responsibility of
> pushing a new patch that fixes the nits that they found.
In the past this is something that I have wanted to do but have received 
mixed feedback on its level of appropriateness.  I am happy to push 
follow-up patches to address nit-picks rather than hold up a patch.  We, 
however, will need to communicate to the community that this is now an 
acceptable practice.

> On Tue, May 29, 2018 at 9:55 AM, Julia Kreger
> <juliaashleykreger at gmail.com> wrote:
>> During the Forum, the topic of review culture came up in session after
>> session. During these discussions, the subject of our use of nitpicks
>> were often raised as a point of contention and frustration, especially
>> by community members that have left the community and that were
>> attempting to re-engage the community. Contributors raised the point
>> of review feedback requiring for extremely precise English, or
>> compliance to a particular core reviewer's style preferences, which
>> may not be the same as another core reviewer.
>> These things are not just frustrating, but also very inhibiting for
>> part time contributors such as students who may also be time limited.
>> Or an operator who noticed something that was clearly a bug and that
>> put forth a very minor fix and doesn't have the time to revise it over
>> and over.
>> While nitpicks do help guide and teach, the consensus seemed to be
>> that we do need to shift the culture a little bit. As such, I've
>> proposed a change to our principles[1] in governance that attempts to
>> capture the essence and spirit of the nitpicking topic as a first
>> step.
>> -Julia
>> ---------
>> [1]: https://review.openstack.org/570940
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list