[openstack-dev] [horizon][neutron] tools/tox_install changes - breakage with constraints

Akihiro Motoki amotoki at gmail.com
Wed Mar 14 22:16:11 UTC 2018

The current version of proposed patches which drops tox_install.sh
works in our CI. Even if we have neutron>=12.0.0 (queens) or
horizon>=13.0.0 (queens), if we have "required-projects" in zuul v3
config, tox-sibling role ensures to install the latest master of
neutron/horizon. It is okay in our CI.

On the other hand, this change brings a couple of problems. I think it
is worth discussed broadly here.

(1) it makes difficult to run tests in local environment
We have only released version of neutron/horizon on PyPI. It means
PyPI version (i.e. queens) is installed when we run tox in our local
development. Most neutron stadium projects and horizon plugins depends
on the latest master. Test run in local environment will be broken. We
need to install the latest neutron/horizon manually. This confuses
most developers. We need to ensure that tox can run successfully in a
same manner in our CI and local environments.

(2) neutron/horizon version in requirements.txt is confusing
In the cycle-with-milestone model, a new version of neutron/horizon
will be released only when a release is shipped.
The code depends on the latest master, but requirements.txt says it
depends on queens or later. It sounds confusing.


2018-03-15 6:56 GMT+09:00 Andreas Jaeger <aj at suse.com>:
> On 2018-03-14 20:46, Andreas Jaeger wrote:
>> On 2018-03-14 20:39, Andreas Jaeger wrote:
>>> We now have neutron and horizon in global-requirements and do not need
>>> to install them anymore with tools/tox_install.sh.
>>> This allows to simplify our jobs and testing.
>>> Unfortunately, the merging caused now the projects that install neutron
>>> and horizon via tools/tox_install to break with constraints.
>>> I'm currently pushing up changes for these using topic tox-siblings [1].
>>> Please merge those - and if you're pushing up changes yourself, let's
>>> use the same topic.
>>> Sorry for the breakage ;(
>>> Andreas
>>> [1] Links
>>> https://review.openstack.org/#/q/topic:tox-siblings+(status:open+OR+status:merged)
>> Note that thanks to the tox-siblings feature, we really continue to
>> install neutron and horizon from git - and not use the versions in the
>> global-requirements constraints file,
> Btw. this work is part of what Monty proposed in
> http://lists.openstack.org/pipermail/openstack-dev/2017-November/124676.html
> Andreas
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>    GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>        HRB 21284 (AG Nürnberg)
>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list