[openstack-dev] [ironic] should we provide 'ironic node-list --chassis' and 'ironic port-list --node' commands?

Loo, Ruby ruby.loo at intel.com
Mon Sep 12 13:31:47 UTC 2016


Vlad was the only one that was luke-warm in favour of 'ironic node-list --chassis'. Since I haven't received any positive, enthusiastic comment about wanting it, I don't think it is worth spending any more time pursuing it.

'openstack baremetal node list --chassis' does exist though (in 1.7.0 [1]).


[1] http://docs.openstack.org/releasenotes/python-ironicclient/newton.html

On 2016-08-30, 11:57 AM, "Vladyslav Drok" <vdrok at mirantis.com<mailto:vdrok at mirantis.com>> wrote:

The ironic node-list --chassis seems to be easier to understand for me. I've commented on one of the patches that maybe we should deprecate the chassis-node-list if we add this, but then, the deprecation is slow, we have some functional tests already... Having two commands kind of reflects the duplication in our API, where we can do /chassis/<UUID>/nodes and /nodes?chassis_uuid=<UUID>, so maybe having both of them is fine.


On Mon, Aug 29, 2016 at 7:22 PM, Loo, Ruby <ruby.loo at intel.com<mailto:ruby.loo at intel.com>> wrote:

While working on the openstackclient plugin commands for ironic, I was thinking about the equivalents for 'ironic chassis-node-list' (nodes that are part of specified chassis) and 'ironic-node-port-list' (ports that are part of specified node). It didn't make sense to me to have an 'openstack baremetal chassis node list', since a 'chassis' and a 'node' are two different objects in osc lingo and we already have 'openstack baremetal chassis xx' and 'openstack baremetal node yy' commands. Furthermore, our REST API supports 'GET /v1/nodes?chassis=c1' and 'GET /v1/ports?node=n1'.

So I proposed 'openstack baremetal node list --chassis' and 'openstack baremetal port list --node' [1]. To implement this, I need to enhance our corresponding python APIs. The question I have is whether we want to only enhance the python API, or also provide 'ironic node-list --chassis' and 'ironic port-list --node' commands. The latter is being proposed [2] and coded at [3]. Doing this would mean two different ironic CLIs to do the same thing, but also provide a more obvious 1:1 correspondence between ironic & osc commands, and between ironic CLI and python API.


It'd be great if we could decide in the next day or so, in order to get the osc-related commands into the client this week for the Newton release.


[1] http://specs.openstack.org/openstack/ironic-specs/specs/approved/ironicclient-osc-plugin.html#openstack-baremetal-node
[2] https://launchpad.net/bugs/1616242
[3] https://review.openstack.org/#/c/359520/

OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160912/61b37a3b/attachment.html>

More information about the OpenStack-dev mailing list