[openstack-dev] [all] Using \ for multiline statements
openstack.org at sodarock.com
Fri Dec 23 21:28:00 UTC 2016
On Fri, Dec 23, 2016 at 1:11 PM, Monty Taylor <mordred at inaugust.com> wrote:
> I think this is the most important point. We have automated style tools.
> Humans should not be doing code review on code style. Humans should be
> doing code review on logic and intent and whether a design is a good
> idea or whether their colleague may have missed an error case or what
> have you.
> We have tools for enforcing things like tests running and code style
> conforming. Let the tools do their job so the humans can focus on being
I'll somewhat disagree. If code style impacts code readability then I think
it is useful to review that. I don't want unreadable code to land because
the automated style checkers don't complain. Basically use common sense.
This passes code style checks:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev