[openstack-dev] [neutron] -2'ing all patches on every gate breakage

Anita Kuno anteaya at anteaya.info
Mon Apr 4 16:13:16 UTC 2016

On 04/04/2016 12:01 PM, Ihar Hrachyshka wrote:
> Hi all,
> I noticed that often times we go and -2 all the patches in the review
> queue on every neutron specific gate breakage spotted. This is allegedly
> done to make sure that nothing known to be broken land in merge gate
> until we fix the breakage on our side.
> While I share the goal of not resetting the gate if we can avoid it, I
> find the way we do it a bit too aggressive. Especially considering that
> often times those -2 votes sit there not cleared even days after the
> causing breakage is fixed, needlessly blocking patches landing.
> I suggest we either make sure that we remove those -2 votes right after
> gate fixes land, or we use other means to communicate to core reviewers
> that there is a time window when nothing should land in the merge queue.
> Thanks,
> Ihar
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Well one thing that could be done is that one of the core reviewers go
into gerrit and remove everyone else from the core review group until
merging is permitted again.

It avoids the -2'ing everything and then having to clean up, but would
really have to be socialized and accepted by everyone affected prior to
being implemented, lest it create issues of a different kind.


More information about the OpenStack-dev mailing list