Open Stack

On Mon, Jun 15, 2015 at 4:16 PM, Thomas Goirand <zigo at debian.org> wrote:

> On 06/15/2015 11:31 AM, Joe Gordon wrote:
> > Nova itself doesn't depend on suds anymore.
>
> A quick grep still shows references to suds (that's in Kilo, but the
> master branch shows similar results):
>

Your git repo is out of date.


https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=suds


>
> etc/nova/logging_sample.conf:qualname = suds
>

this doesn't actually require suds.

We can remove this line


>
> nova/tests/unit/test_hacking.py:            " def
> fake_suds_context(calls={}):"))))
>
> nova/tests/unit/virt/vmwareapi/test_vim_util.py:        with
> stubs.fake_suds_context(calls):
>
> nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):
>
> nova/tests/unit/virt/vmwareapi/stubs.py:    """Generate a suds client
> which automatically mocks all SOAP method calls.
>
> nova/tests/unit/virt/vmwareapi/stubs.py:
> mock.patch('suds.client.Client', fake_client),
>
> nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds
>
> nova/tests/unit/virt/vmwareapi/test_driver_api.py:
> mock.patch.object(suds.client.Client,
>
> nova/tests/unit/virt/vmwareapi/fake.py:    """Fake factory class for the
> suds client."""
>
> nova/tests/unit/virt/vmwareapi/fake.py:        """Initializes the suds
> client object, sets the service content
>
> nova/virt/vmwareapi/vim_util.py:import suds
>

this was removed in https://review.openstack.org/#/c/181554/


>
> nova/virt/vmwareapi/vim_util.py:    for k, v in
> suds.sudsobject.asdict(obj).iteritems():
>
> nova/config.py:                       'qpid=WARN', 'sqlalchemy=WARN',
> 'suds=INFO',
>

We missed this, so here is a patch https://review.openstack.org/#/c/191795/


>
> test-requirements.txt:suds>=0.4
>
>
> > Oslo.vmware has a suds
> > dependency, but that is only needed if you are using the vmware virt
> > driver in nova.
>
> It's used in unit tests, no?
>

as explained above, nope.


>
> > So nova's vmware driver depends on suds (it may be suds-jurko these
> > days)
>
> As I wrote, suds-jurko isn't acceptable either, as it's also not
> maintained upstream.
>

Agreed, we have more work to do.


>
> > but not nova in general.
>
> If we don't want suds, we don't want suds. Not just "it's only in some
> parts" kind of answer. Especially, it should appear in
> tests-requirements.txt and in vmwareapi unit tests. Don't you think?
>
> Cheers,
>
> Thomas Goirand (zigo)
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150615/a72ee3f3/attachment.html>