<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 15, 2015 at 4:16 PM, Thomas Goirand <span dir="ltr"><<a href="mailto:zigo@debian.org" target="_blank">zigo@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On 06/15/2015 11:31 AM, Joe Gordon wrote:<br>
> Nova itself doesn't depend on suds anymore.<br>
<br>
</span>A quick grep still shows references to suds (that's in Kilo, but the<br>
master branch shows similar results):<br></blockquote><div><br></div><div>Your git repo is out of date.</div><div><br></div><div><br></div><div><a href="https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=suds">https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=suds</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
etc/nova/logging_sample.conf:qualname = suds<br></blockquote><div><br></div><div>this doesn't actually require suds.</div><div><br></div><div>We can remove this line</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
nova/tests/unit/test_hacking.py: " def<br>
fake_suds_context(calls={}):"))))<br>
<br>
nova/tests/unit/virt/vmwareapi/test_vim_util.py: with<br>
stubs.fake_suds_context(calls):<br>
<br>
nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):<br>
<br>
nova/tests/unit/virt/vmwareapi/stubs.py: """Generate a suds client<br>
which automatically mocks all SOAP method calls.<br>
<br>
nova/tests/unit/virt/vmwareapi/stubs.py:<br>
mock.patch('suds.client.Client', fake_client),<br>
<br>
nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds<br>
<br>
nova/tests/unit/virt/vmwareapi/test_driver_api.py:<br>
mock.patch.object(suds.client.Client,<br>
<br>
nova/tests/unit/virt/vmwareapi/fake.py: """Fake factory class for the<br>
suds client."""<br>
<br>
nova/tests/unit/virt/vmwareapi/fake.py: """Initializes the suds<br>
client object, sets the service content<br>
<br>
nova/virt/vmwareapi/vim_util.py:import suds<br></blockquote><div><br></div><div>this was removed in <a href="https://review.openstack.org/#/c/181554/">https://review.openstack.org/#/c/181554/</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
nova/virt/vmwareapi/vim_util.py: for k, v in<br>
suds.sudsobject.asdict(obj).iteritems():<br>
<br>
nova/config.py: 'qpid=WARN', 'sqlalchemy=WARN',<br>
'suds=INFO',<br></blockquote><div><br></div><div>We missed this, so here is a patch <a href="https://review.openstack.org/#/c/191795/">https://review.openstack.org/#/c/191795/</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
test-requirements.txt:suds>=0.4<br>
<span class=""><br>
<br>
> Oslo.vmware has a suds<br>
> dependency, but that is only needed if you are using the vmware virt<br>
> driver in nova.<br>
<br>
</span>It's used in unit tests, no?<br></blockquote><div><br></div><div>as explained above, nope.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br>
> So nova's vmware driver depends on suds (it may be suds-jurko these<br>
> days)<br>
<br>
</span>As I wrote, suds-jurko isn't acceptable either, as it's also not<br>
maintained upstream.<br></blockquote><div><br></div><div>Agreed, we have more work to do.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br>
> but not nova in general.<br>
<br>
</span>If we don't want suds, we don't want suds. Not just "it's only in some<br>
parts" kind of answer. Especially, it should appear in<br>
tests-requirements.txt and in vmwareapi unit tests. Don't you think?<br>
<div class=""><div class="h5"><br>
Cheers,<br>
<br>
Thomas Goirand (zigo)<br>
<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>