[openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
filip.blaha at hp.com
Wed Jun 10 15:00:39 UTC 2015
Thanks for comment and suggestion!
there is also shutil2 framework for unit testing over shell scripts. We
shall consider it whether it could bring us value for the effort. I
personally have no strong opinion about that. Little contradiction to my
On 06/10/2015 03:34 PM, Jeremy Stanley wrote:
> On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote:
>> +1, nice idea. Shell script are not easy to review - large files, not
>> covered by unit tests. Any automatic tool could be beneficial.
> It's worth noting that just because your shell scripts don't have
> their own validation tests doesn't mean they can't. For example see
> the test-features.sh and test-functions.sh scripts in the
> https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo,
> making sure we maintain a contract on things like branch fallback
> logic which is easy to subtly break if not tested.
More information about the OpenStack-dev